Sanity check : example wiki configs and prop replacement ?

[Tom Zeller]

On Thu, Feb 5, 2015 at 10:17 AM, Rod Widdowson <rdw at steadingsoftware.com> wrote:
>> I have not looked extensively, but I think that most example
>> configurations on the wiki should use "%" instead of "$" for property
>> replacement, and references to conf/property-placeholder.xml should be
>> removed. If I'm correct, updating the docs accordingly could be a new
>> issue or part of another, not sure where we are at exactly with that.
>
> Is this in the RDBMS connector example?  It worried me that the samples say
> "%s" but they are velocity properties and so $ seemed correct.
>
> If they are for the springResource (for instance what is currently sitting
> at https://wiki.shibboleth.net/confluence/display/IDP30/LDAPConnector) then
> I need to review the code and the example - these spring files are a bit
> special.
>
> If it's neither (like any of the native syntax files for relyingParty or so
> on) can you point me at (some of) them and I'll get back to you.    It feels
> like it's an error to me.

I was looking at the metadata example[1] when I noticed the "$", which
doesn't work OOTB.
I was looking at the example attribute resolver activation
condition[2] when I noticed the "conf/property-placeholder.xml".

In some config files (services.xml), both "$" and "%" resolve
correctly, but I do not at the moment recall the hairy details.

So, maybe the issue/task is "understand and document property
placeholders" so we can explain to deployers which works where.

[1] https://wiki.shibboleth.net/confluence/display/IDP30/MetadataConfiguration
[2] https://wiki.shibboleth.net/confluence/display/IDP30/ExternalAttributePluginActivationConditions