Proposal to resolve entities by role+protocol

[Cantor, Scott]

On 12/7/15, 4:53 PM, "dev on behalf of Marvin Addison" <dev-bounces at shibboleth.net on behalf of marvin.addison at gmail.com> wrote:


>
>I would appreciate review and feedback. I'm not wedded to this approach; I'm just trying to move the ball forward on what I need for IDP-701. That said, the patch does provide a feature mentioned in Brent's TODO comments, so it's arguably generally beneficial. The biggest concern I guess is the functional change from requiring an EntityIdCriterion to being more flexible about required criteria.

Brent knows the APIs better than I do, but I'll just say that this seems to break the current separation between the MetadataResolver type and the RoleDescriptorResolver. Seems like we need to rationalize that one way or the other. It would seem odd to support role-based criteria above, but keep the RoleDescriptorResolver in there.

-- Scott