Registering flow locations by pattern on Windows

[Misagh Moayyed]

Perhaps a catch-all fix would be to always normalize the idp.home path in
IdPPropertiesApplicationContextInitializer ? And, it think it would be a
good to break apart IdPPropertiesApplicationContextInitializer into
smaller methods that can be overridden. 

 

From: dev [mailto:dev-bounces at shibboleth.net] On Behalf Of Misagh Moayyed
Sent: Thursday, August 13, 2015 3:07 AM
To: Shib Dev <dev at shibboleth.net>
Subject: Registering flow locations by pattern on Windows

 

I have just found what appears to be a strange issue/bug with Spring
webflow, when the idp attempts to register flow definitions by a pattern
off a base path that id the IDP_HOME. Here's the case: 

 

- You might decide that you want to run the idp off of a non-standard
location, by specifying the idp.home settings

- When you do, and you're doing this on windows and not via an installer,
it's common to state that location via backslashes rather than forward
slashes. 

- This completely breaks SWF, when it attempts to auto-construct ids for
flow definitions. It wants to manipulate the path to build a flow id, and
it does this by ripping out the basepath from the resource path. Because
the base path is with "\", and yet the resource path is located with "/",
the attempt fails. 

- As a result, none of the AuthN/conditions flows are built. Sad Panda. 

 

Has anyone else on the dev team run into this issue? Specifically those
that run on Windows? I am running this with IdP 3.1.3-SNAPSHOT; I see the
Windows Installer corrects this issue by specifying "/"s instead. 

 

Misagh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20150813/139ee95d/attachment.html>