Result set handling bugs

Cantor, Scott cantor.2 at osu.edu
Thu Oct 16 15:28:04 EDT 2014


I uncovered a number of issues with the JDBC connector's result set
handling, and I wanted to note it in case the LDAP connector needs any
review, since that is not likely to get tested much by my production
scenarios and configs.

In particular, I'd make sure to test for handling multiple results back.

I'm taking a wack at fixing the JDBC code, but I think one issue is just
unfixable, the contract with the IdPAttribute class is just not the same
as in V2 with BasicAttribute because the value objects won't be directly
visible. The old code would put actual objects from the JDBC API into the
value collection, and the new one requires they be wrapped in
IdPAttributeValue instances.

Hopefully that doesn't cause any issues. I'm wondering if given that
difference we should just deprecate/warn on the type remapping config from
V2 since the result of it won't be code compatible in V3 anyway. Saves me
some time.

But I do need the column rename capability (I could do it in the SQL, but
the XML syntax for this supported mapping two columns into one attribute,
which I don't use but was supported, so we shouldn't break it).

-- Scott



More information about the dev mailing list