Consent notes while testing

[Tom Zeller]

On Mon, Nov 17, 2014 at 1:12 PM, Cantor, Scott <cantor.2 at osu.edu> wrote:
> I'm playing with this now for the first time. I guess we're doing
> per-attribute consent? ;-)

Shrug, yes. It's a toggle on the attribute release flow descriptor, so
whichever way is fine with me. The default is in
system/profile-intercept-system.xml and of course should be overriden
in userspace in conf/intercept/profile-intercept.xml.

> I'm going to check in some message wording tweaks (mainly
> s/data/information) because I think the word data is offputting. YMMV.

Thanks for looking at it. I spent a little time porting that wording
from uApprove-JP, but I was really not sure what the default should
be.

> Questions:
>
> Is that springMessage macro function built-in to Spring?

Yes. [1] And, springMessageText() accepts the default text as a third
argument, but since it's message source based that seemed like too
much.

> The "Reject" button option seems like it should signal an error event,
> probably. Is that the intent and it's just not done yet?

No, I reproduced the current uApprove behavior. If we want to change
that into an error event, sure I'll take the help.

[1] https://github.com/spring-projects/spring-framework/blob/master/spring-webmvc/src/main/java/org/springframework/web/servlet/view/velocity/spring.vm