fixing the crypto factory beans

[Brent Putman]

On 5/29/14 11:00 AM, Cantor, Scott wrote:
>> Question: do we think I am missing any other significant uses of these
>> classes in the wild, or in our own code?
> Nothing I've done. I was assuming that the custom schema parsing was using
> them, but it looks like they call KeySupport-type functions directly.


I don't know of anything either.  I always assumed Chad did them
primarily to support the MDA and/or xmlsectool.  Other than that, I just
know of the stuff in the v3 IdP.

>
>> I think File was the wrong starting point for these classes, so my
>> preference would be to remove the existing methods with the File
>> argument, establish new methods taking Resource instead, and adjust
>> configurations everywhere as required.
> Yes, I would think so.

I agree, Resource is more flexible and makes more sense there.


>
>> Question: any rationale for
>> setCertificateResource/setPrivateKeyResource/etc. vs. setResource?
> Depends where the methods live I guess. If you have a class that has to
> take multiple separate resources, we'd need to clarify which was which.


Agreed.  Doesn't look like any of the current ones take more than one
File/resource type thingy.  I personally don't have a strong preference.


>
>> Bottom line: I have reasons to want to just get this cleared out now, and
>> apart from those I also think this deserves to be fixed for the IdP
>> alpha. Unless there's a good reason against doing this, I'd like to just
>> get it done.
> Please.
>
>

I second the motion!




-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://shibboleth.net/pipermail/dev/attachments/20140529/20c332c9/attachment.html