fixing the crypto factory beans

Cantor, Scott cantor.2 at osu.edu
Thu May 29 11:00:24 EDT 2014


>There are also some uses of these beans in the IdP, both in places like
>the testbed and also in places like credentials.xml in idp-conf. That
>looks like it's going to be exposed to IdP deployers, so if we are going
>to make changes in this area I'd say it would be better to get it done
>before the alpha (i.e., ASAP).

I wasn't sure what I was meant to do to load credentials, and I was
actually considering whether to just use the custom schema we already
defined for this instead of native.

>Question: do we think I am missing any other significant uses of these
>classes in the wild, or in our own code?

Nothing I've done. I was assuming that the custom schema parsing was using
them, but it looks like they call KeySupport-type functions directly.

>I think File was the wrong starting point for these classes, so my
>preference would be to remove the existing methods with the File
>argument, establish new methods taking Resource instead, and adjust
>configurations everywhere as required.

Yes, I would think so.

>Question: any rationale for
>setCertificateResource/setPrivateKeyResource/etc. vs. setResource?

Depends where the methods live I guess. If you have a class that has to
take multiple separate resources, we'd need to clarify which was which.

>Bottom line: I have reasons to want to just get this cleared out now, and
>apart from those I also think this deserves to be fixed for the IdP
>alpha. Unless there's a good reason against doing this, I'd like to just
>get it done.

Please.

-- Scott




More information about the dev mailing list