[java-parent-projects COMMIT] /java-parent-project-v3/trunk/pom.xml
Tom Zeller
tzeller at dragonacea.biz
Thu May 22 10:54:34 EDT 2014
>>> I just noticed this. Did we discuss this on the call, etc, and I missed?
>>
>> No, I wondered also.
>>
>> I had been assuming 3.0.
>
> We can downgrade, I made the choice quickly. I also intend to explain, got busy with other stuff. At the least, we can talk Friday.
So ... first, I was wrong about Jetty-to-Servlet version mappings. I
was thinking that Jetty 9.1 was Servlet 3.0 and Jetty 9.2 was Servlet
3.1, but both Jetty 9.1 and 9.2 are Servlet 3.1.
Second, I wanted to use the latest Jetty to take advantage of the
patch which allows for property files external to the jetty.base and
jetty.home directories. However, I don't think we need this anymore,
nor did we really need it to begin with. It seems a cleaner separation
of the IdP and Jetty for jetty.xml and idp.ini, which contains jetty.*
properties copied from idp.properties, to be in jetty-base in
idp-distribution. I have not removed the jetty.* properties from
idp.properties because I just had not got that far yet, there is work
to do to reconfigure the testbed and integration-tests accordingly.
I'm okay that I submitted the patch, because I had to work it out
anyway trying to figure out if either I was incorrect or the Jetty
docs.
I guess third, I feel like I should know why the
java-idp-integration-tests passed for Jenkins but not for me nor Rod.
After bumping Jetty to 9.1 in the parent-v3 POM, the integration-tests
threw an error related to a Servlet 3.1 class not found, but not for
Jenkins.
And fourth, when I realized that Servlet 3.1 required a couple of
changes to the ThreadLocal*Proxy classes, I went ahead and upgraded
thinking that we were going to have to do this someday anyway, and
since I was there, I might as well do it, knowing full well we may
revert. Personally, I do not understand how to take advantage of the
session fixation attack enhancement in Servlet 3.1, but I thought
someone else would and maybe we would want it.
I am okay with targeting Servlet 3.0 for IdP 3.0, but I guess that
ties us to Jetty 9.0, and development is happening on the 9.1 and 9.2
branches, so I was a little less excited about that. I don't really
know as much regarding Tomcat development.
More information about the dev
mailing list