Actions should not be Identifiable ?
Cantor, Scott
cantor.2 at osu.edu
Mon Mar 24 22:58:00 EDT 2014
On 3/24/14, 10:52 PM, "Tom Zeller" <tzeller at dragonacea.biz> wrote:
>> But I think IDable and Initable are just separate ideas, personally, and
>> shouldn't be linked.
>
>Understood. But it seems to make sense for getId() to be
>@NonnullAfterInit, which bundles IDable and Initable.
I agree that it's a problem, but I'm less concerned with IDable requiring
Initable than the opposite.
>I think I might be conflating ID and the log prefix.
It's not as though we ever had that concept before. The only reason I
created that method for the actions was because the existing code had a
ton of duplication all over, with the log messages containing the same
information. I personally would have been fine just removing that part. To
me, the log messages should just be bound to a category, and anything else
should be part of the logging context, not the logging message.
-- Scott
More information about the dev
mailing list