Refactored flows
Cantor, Scott
cantor.2 at osu.edu
Mon Mar 10 15:51:30 EDT 2014
I did a major refactor of the flows and beans for the two SSO flows. All
the actions and beans generally common to all SAML profiles (or that I
think will be common) are in a parent flow and the "meat" is left out to
be declared by a child flow.
Some of the actions there depend on beans declared down lower, but since
every flow has its own context essentially, this seems to work ok. Sort of
late binding of beans from a declaration standpoint.
The SSO flows are then stripped of everything but the middle part. I then
redid the SAML 2 flow to remove basically all of the testbed actions and
beans so it's a copy of the SAML 1 flow with the version-specific actions
changed to their SAML 2 versions. The tests still pass.
What's broken now is the limited error handling the testbed was doing, but
that's probably the next big area to work on anyway, and I wanted to make
sure the refactoring worked for both versions.
Time will tell if this factoring works for attribute query, but that's
going to be pretty easy to throw together and check now since it's much
simpler. Assuming all the SOAP messaging just works anyway.
I will see about adding some more test asserts also, since I fixed some
profile bugs.
-- Scott
More information about the dev
mailing list