Thoughts on system properties for startup

Cantor, Scott cantor.2 at osu.edu
Wed Jun 18 18:39:37 EDT 2014


On 6/18/14, 5:25 PM, "Tom Zeller" <tzeller at dragonacea.biz> wrote:
>
>Now that you've said this a couple of times I think I am getting it
>now : avoid the property just for the userFlowRegistry base-path and
>document not to use backslashes. Okay.

Maybe. I'm not sure we can avoid the special property because my
workaround really was addressing the specific case of a path in idp.home,
and hardwiring the webflow config to use file: in front of it. If we want
to allow for non-files there, we'd have to define a property anyway. I
just want it to be specific to that need because the webflow logic really
is very particular and unusual.

But for now, we could deal with that later and just use
file:${idp.home}/flows in the config.

>So, if someones does use backslashes in idp.home, SWF will throw a
>FlowExecutionException with, for example, root cause
>NoSuchFlowModelException "No flow model 'auth/conditions' found". Is
>that okay ? Should the app ctx initializer look for backslashes in
>idp.home and warn ?

Yeah, I think it's worth warning on that. I'm even ok converting them if
it's a universal fix. I just didn't want to define a special property for
that and end up with it only working for some things. But I think warning,
or even just failing outright on it, is probably enough.

-- Scott




More information about the dev mailing list