SP credential in attribute query flow tests ?

[Cantor, Scott]

On 6/2/14, 2:23 PM, "Tom Zeller" <tzeller at dragonacea.biz> wrote:

>> I'm not sure what you're commenting out, but that doesn't sound related
>>to
>> the server side of the tests. The credential for the SP comes from the
>> metadata.
>>
>> Where is the code you're turning off?
>
>Lines 92 and 93 in SAML1AttributeQueryFlowTest, for example :
>
>92 : 
>request.setAttribute(ServletRequestX509CredentialAdapter.X509_CERT_REQUEST
>_ATTRIBUTE,
>93 :             new X509Certificate[] {certFactoryBean.getObject()});

Ok, I had thought the tests actually issued a localhost loopback HTTP
request, rather than mocking a ServletRequest up.

Yeah, you're right, this doesn't look right. I think the
CheckMandatoryAuthentication rule is either not running or is getting bad
data.

Since I know my own tests from the command line were failing, I suspect
maybe something is mocking up the inbound message context in such a way
that the authenticated flag is on when it shouldn't be, but we'll have to
trace into it.

I'll re-verify that my command line tests with the SP still fail with no
TLS cert.

-- Scott