Logging nit

Cantor, Scott cantor.2 at osu.edu
Wed Jul 30 13:51:02 EDT 2014


Something to keep an eye on, we have a lot of logging bugs where we're
passing exceptions into "{}" substitutions in the format strings, which
isn't generally what we want.

The logging API doesn't have log methods that take variable arguments
*and* take exceptions explicitly. If you pass an exception in, you have to
make sure to not use {} placeholders, I think. Otherwise log config
controlling things like exception stack traces won't work right.

We can probably sanity check by searching for lines ending in ",e);" or ",
e);".

I'll create a bug for it.

-- Scott



More information about the dev mailing list