Moving the service stuff down

Tom Zeller tzeller at dragonacea.biz
Mon Jul 21 12:02:54 EDT 2014


>>>Secondly other major consumer of the base class (apart from the
>>>RealodableSpringService implementation) is the log back service.  We are
>>>now
>>>in a position to move this down into java support.
>>>
>>>I have not done this since I am not convinced that this is a good idea,
>>>it
>>>will a dependency on our particular choice of logging down into
>>>java-support
>>>and the evidence in the POM is that we don't want to do this.
>>
>>Probably as an optional dependency though, that seems to be the nature of
>>most of that library.

The java-support POM already has logback-core and logback-classic
dependencies, I guess for the LogbackConfigurationListener, so it
seems our logging choice is already present.

>>I suppose I can imagine the MDA wanting to use it, so it's largely the
>>same consideration as the other things.
>
> Currently however the logging service has some dependencies on IDP_HOME,
> so that would have to be factored out or adjusted to be more general.
> Probably not worth it much at this stage.

I think you already closed the issue, but ... we could move the
LogbackLoggingService with the IDP_HOME stuff removed to java-support,
and let a child class in idp-core provide that hack. Like Soctt said,
not much worth it unless other projects could use the base class.


More information about the dev mailing list