IdP version in the code

[Brent Putman]

On 7/18/14, 4:48 PM, Cantor, Scott wrote:
> I think some people have, but I've run the code myself in V2 and it seemed
> to work. I don't know how or why. It's extremely convoluted, presumably
> for the purpose of avoiding having to maintain a version string, but
> sometimes manual is the simplest.

Agreed, see below, I think we already have this for free...

> I finally re-tracked it down, the way it works is with a maven-jar-plugin,
> it injects the version manifest into the built jar, it's not in the source
> tree. So the version is derived from the POM at build-time.

I've never quite understood how that stuff worked in v3, using the Java
package implementation manifest stuff.

> And this doesn't work for V3 right now because the idp-conf POM never
> actually builds a jar.


I have wondered if it would not be simpler to just use the Maven POM
data that it puts in the jar(s), and just pull the version string out. 
It's already there, so we get it for free.  For example, from idp-core jar:

META-INF/maven/net.shibboleth.idp/idp-core/pom.xml
META-INF/maven/net.shibboleth.idp/idp-core/pom.properties

There's a 'version' property right in the properties file.  Would
probably be only a few lines of code to read that in as a Property
resource and pluck that out.  Unless I'm missing something.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://shibboleth.net/pipermail/dev/attachments/20140718/ca414b41/attachment.html