SAML1 CheckRequestVersionHandler ClassCastException ?

[Cantor, Scott]

On 1/22/14, 10:25 PM, "Brent Putman" <putmanb at georgetown.edu> wrote:
>
>Btw, on the CheckRequestVersionHandlers themselves: I don't recall every
>doing any MessageHandlers for SAML that were paramed more specifically
>than SAMLObject, like Scott did there.  As long as we're careful not to
>wire the wrong one on the wrong flow, it's
> fine.  But I probably would have done this differently, by just having a
>single impl that processed messages of type SAMLObject, had a property
>slot for the acceptable SAMLVersion(s) and then a "smart" property on one
>of the contexts (e.g. SAMLMessageInfoContext)
> that knew how to pluck SAMLVersion out of the inbound message.

It was Chad's, I just ported the actions that were done already into
handlers to clean them up. The actions were already typed that way. I
don't care either way.

But in this case, there is no message version, so there's not much
difference in outcome, it would still break if it were wired into that
flow, or I guess it could just silently do nothing, but that probably
wouldn't be sensible for a handler meant to check that a version actually
matches.

-- Scott