IdpAttribute#getValues()

[Tom Zeller]

>> I'm not a huge fan of add/remove either. But my main question is whether
>> this affects compatibility at all in the scriptlets.
>
> No, because the scriptlets have to present a variation of the Attribute
> which matches V2 (in which getValues() returns a Collection<String>, not a
> Collection<IdPAttributeValue<?>>) so we wrap the IdPAttribute in a
> ScriptAttribute which 'does the right thing' (tm).  New Scripts can access
> the real IdPAtribute through a new method and that will be constrained, but
> that's OK.  I actually flushed a bug in this code while testing which I'll
> check in separately.
>
> I should emphasise that this is just bring the attribute values into line
> with the rest of the IdP code, as per our discussions last summer (when we
> also decided that although we might like to we were *not* going to retrofit
> OpenSAML)

Nice.