bike part reward : setting bean ID property automatically

Rod Widdowson rdw at steadingsoftware.com
Fri Feb 14 07:43:50 EST 2014


I think Ian has said everything I wanted to mention, so I'll not duplicate
that.

> Probably move what I did to a new BeanPostProcessor.

In IdP-spring I guess?  I am conflicted as to whether the exiting bean
processor should go there, but on balance keeping it close to the types it
manipulates seems best.

... Or do we want to put this into Spring-extensions?  Ian, would the MDA
benefit from this?

> > I am okay with log.warn in the long term, curious why you suggest
> > short term only.
> 
> I'd be mildly against leaving something like a warning in there to clutter
up log
> files. It's not as if we're "warning" about a condition which can cause
any
> problems. I have *hundreds* of such bean declarations today.

That was my point.  In order to be visible I'd probably put it in as an
ERROR and we certainly don't want that to last.  I suppose one could put it
out as TRACE, but does it really matter ?  - once we have cleaned up our
configs.   I'm guessing that all configuration from now on is going to be
cut and paste (which is why I think removing this now is important), so I
don't see that as a common case, once we are done.  Leaving it in has a
minor benefit in that it then becomes a suitable place to put a breakpoint,
but would we want to?

/Rod




More information about the dev mailing list