Add caught exceptions to event returned from action ?

[Cantor, Scott]

On 2/6/14, 7:59 PM, "Cantor, Scott" <cantor.2 at osu.edu> wrote:

>On 2/6/14, 7:51 PM, "Tom Zeller" <tzeller at dragonacea.biz> wrote:
>
>>In Actions, caught exceptions should be added to the returned Event,
>>correct ?
>
>I don't think there's a systematic way to do it, which is why I captured
>exceptions in the context tree where it seemed valuable. In most cases,
>it's not valuable, it's just an error to log. If we need to propagate the
>"type" of error, I think we should try to do that with event IDs, not by
>propagating the exception.

This reminds me, as a more general comment, I've been pretty studiously
avoiding logging at ERROR for things that are actually runtime conditions
that might happen. I see that more as a WARN. I don't like ERROR being
used for things caused by external conditions/factors like a user hitting
a back button. This is a major hassle with the IdP logging today. ERROR
should mean "hey, check this out and fix it". IMHO at least.

Config time mistakes, ERROR works fine though.

-- Scott