An annoying nit in Spring parsing
Daniel Fisher
dfisher at vt.edu
Fri Aug 8 10:22:15 EDT 2014
On Fri, Aug 8, 2014 at 7:40 AM, Rod Widdowson <rdw at steadingsoftware.com> wrote:
> My apologies if this is well-known information, but I just got bitten and
> thought I should share.
>
> I was trying to find the source of this log message:
>
>> DEBUG
> [net.shibboleth.ext.spring.util.SchemaTypeAwareBeanDefinitionParserDelegate:
> 495] - Neither XML 'id' nor 'name' specified - us.....
>
> When the class mentioned had only 68 lines.
>
> It turns out that when that particular base class initializes it says
> "logger = LogFactory.getLog(getClass());"
>
I thought we had a coding standard that dictated the use of
LogFactory.getLog(ThisClass.class).
It's not on https://wiki.shibboleth.net/confluence/display/DEV/Java+Coding+Conventions
but I do remember there was consensus on that.
(I was arguing for the losing side...)
--Daniel Fisher
More information about the dev
mailing list