java-idp-integration-tests and idp-flow-tests ?

[Cantor, Scott]

On 4/22/14, 4:59 PM, "Tom Zeller" <tzeller at dragonacea.biz> wrote:

>Looking for feedback regarding a new project for integration tests and
>a new module for IdP flow tests.

+1

>After botching the commit of the Selenium status servlet test last
>Friday, I realized it is not a good idea to mix integration tests with
>unit tests, especially with Selenium's dependency on Xalan/Xerces.

That's the biggie, I really don't want to have to be screwing with that in
conjunction with the other tests we have. I was waiting to see it fail so
I could see what the actual dependency is. They really are off base with
that code, they shouldn't be depending on any classes specific to Xerces.
Even we never did that.

>So, I thought I should pull Selenium out of the testbed and into a
>project peer to java-identity-provider. If okay, I will go ahead and
>commit, creating a new svn repository 'java-idp-integration-tests' and
>a Jenkins nightly job. Totally open to other names or ideas.

>I also would like to pull the flow tests out of the testbed
>eventually, and I suggest a new idp module 'idp-flow-tests'. Totally
>open to other names, or if folks want to store flow tests in some
>other module. I do not have any work done here, but I thought I would
>poll for feedback.

I'm torn just because it seems odd to have tests as a separate module in
the main project, but maybe that doesn't matter.

Or maybe we could make them tests of idp-conf? I often find myself
flipping back and forth and accidentally running idp-conf by mistake
because I'm usually testing changes in that module.

-- Scott