Reverse attribute mapping..

Tom Zeller tzeller at dragonacea.biz
Tue Sep 24 13:25:30 EDT 2013


>> We currently use "IdPSession" for the primary session object, I think we
>> should move to IdPAttribute for the internal attribute case.
>
> I agree - it gets too confusing and at a purely aesthetic level things like
>
> public abstract class AbstractSAMLAttributesMapper
>         <InType extends org.opensaml.saml.saml2.core.Attribute, OutType
> extends Attribute>
>      implements AttributeMapper<InType, OutType>
>
> are hideous (plus eclipse doesn't line break them properly so you always get
> checkstyle warnings after an autoformat)
>
> Anyone objections to this?  It strikes me that this will be a wide ranging
> checkin so it might serve as a test for the capitalization change process.
> Why don't I try this: Once I have the change ready I'll give people a 24
> hour heads-up to check-in any things they have - or to veto my check-in. To
> be honest I think that this might be overegging things - this sort of change
> is likely to merge up just dandy.

Is the proposal to rename net.shibboleth.idp.Attribute to
net.shibboleth.idp.IdPAttribute ? I don't think so, but I am confused.


More information about the dev mailing list