Shibboleth developer call Friday September 13 11:30 ET

[Brent Putman]

On 9/13/13 10:15 AM, Ian Young wrote:
>
> I don't think we ever reached closure on JPAR-22 (locally disabling Checkstyle in exceptional cases):
>
> https://issues.shibboleth.net/jira/browse/JPAR-22
>
> I think there was a general feeling that something like this was a good idea when we discussed it before, so if people have had a chance to look at it since then perhaps we can just decide to apply the change.


+1 for doing it, I think it will be useful.


>
> I'd propose this as the regex:
>
> 	value="Check[Ss]tyle\:\s*([\w\|]+) OFF"
>
> Thus allowing for either correct or erroneous spelling of Checkstyle, optional space after the colon and anything after the ON|OFF being ignored and usable as a comment.

This looks fine to me, modulo whatever syntactic tweaks you decide on
from the regexes.