Bean names and the Attribute resolution schema files

[Cantor, Scott]

On 9/3/13 6:59 AM, "Rod Widdowson" <rdw at steadingsoftware.com> wrote:

>In order to do this simply I would like to change dataconnector schema
>file
>such that the (fixed) attribute
>
><attribute name="templateEngine" type="string"
>fixed="shibboleth.TemplateEngine">
>
>For the data connectors to becomes
>
><attribute name="templateEngine" type="string"
>fixed="shibboleth.VelocityEngine">

No, please change it so that it's optional, and then default the value in
code to whatever you want it to be.

It was a very bad choice to "fix" bean IDs, and I definitely don't want to
keep that.

>AIUI, the fact that in V2 we always had schema validation means that no
>one
>was ever overriding the value and so changing it should be safe.  But I'd
>like to just check in here before I do this.

It can't be overridden, no, in which case it should never have been
exposed at all. But it's not right to hardwire Spring IDs.

-- Scott