IdPAttribute -> IdentityAttribute ?

[Rod Widdowson]

(Oops, never hit send)

-0.5

1) Whilst I do care about names I don't care enough to add entropy.
However, during my mercifully short exposure to it I did learn to hate
Hungarian.
2) I don't think that this helps in disambiguation which feels like the best
reason to do this.  To me (but bear in mind that I know this code pretty
well) the current code makes it pretty clear what is going on.  

So:

resolver.resolverAttributes(context)
List<IdPAttribute> attributes = context.getResolvedIdPAtributes();

Describes what is going on just as well as your example.
 - IdPAttribute is qualified because of [dis]ambiguation issues.  Hence the
getter id qualified.
 - The local 'context' variable is not ambiguous at this point (I am
assuming) so not qualified)
 - Ditto the local 'attribute'.

FWIW

/R

> -----Original Message-----
> From: dev-bounces at shibboleth.net [mailto:dev-bounces at shibboleth.net]
> On Behalf Of Tom Zeller
> Sent: 24 October 2013 05:15
> To: Shib Dev
> Subject: IdPAttribute -> IdentityAttribute ?
> 
> What do you think, on scale of : ++1, +1, 0, -1, --1 ?
> 
> Code could be :
> 
> IdentityAttribute idAttribute =
> idAttributeResolver.resolveIdentityAttributes()
> 
> or similar.
> 
> I can type a partial proposal if there is any traction.
> --
> To unsubscribe from this list send an email to dev-
> unsubscribe at shibboleth.net