Make all configuration resources abstract ?

Cantor, Scott cantor.2 at osu.edu
Thu Dec 19 14:09:50 EST 2013


On 12/19/13, 2:03 PM, "Tom Zeller" <tzeller at dragonacea.biz> wrote:
>
>Sure. ${idp.sealer.storePath} in system/conf/global-system.xml :
>
><bean id="shibboleth.DataSealer"
>  class="net.shibboleth.utilities.java.support.security.DataSealer"
>  p:keystorePath="${idp.home}/${idp.sealer.storePath}"
>
>in DataSealer :
>
>225 ... setKeystorePath(@Nonnull @NotEmpty final String path) {}
>476 ... new java.io.FileInputStream(keystorePath);

Ah, good point. Bonus points that it's my code.

>The path would remain a string, but we would parse it as an abstract
>resource.

Right. I don't have the Keystore javadocs in front of me, but if we can
consume those via any stream (which seems logical), then that should be
fine.

There may be cases where it also just makes sense to change the delivered
bean file to turn the whole Resource URI into a property and not include
idp.home in the expression.

I wanted to avoid repeating the path all over in the properties file, but
there might be specific cases where that's ok.

-- Scott




More information about the dev mailing list