Coding guidelines adjusted

[Rod Widdowson]

(Mostly for Daniel I think)

As a follow-up from this you will have seen that I have started a pass over
the attribute definitions adding annotations and removing Optional.  

There is one huge checkin coming - the one which will convert.

@Nonnull public final Optional<ResolvedType> resolve(@Nonnull final
AttributeResolutionContext resolutionContext)
            throws ResolutionException

in BaseResolverPlugin to be 

@Nullable ResolvedType resolve(@Nonnull final AttributeResolutionContext
resolutionContext) throws ResolutionException

This will affect pretty much every attribute definition and every data
connector and so I want to pick a time when idp-attribute-resolver-* is
quiescent.

Clearly this is not now since Daniel is about to commit the RDBMS connector.
My question is whether there is any reason why I should not start the edits
once the RDBMS connector is done?

Rod

> -----Original Message-----
> From: dev-bounces at shibboleth.net [mailto:dev-bounces at shibboleth.net]
> On Behalf Of Cantor, Scott
> Sent: 26 April 2013 19:44
> To: Shib Dev
> Subject: Coding guidelines adjusted
> 
> I've updated the coding guidelines to reflect the call today:
> 
> https://wiki.shibboleth.net/confluence/display/DEV/Java+Coding+Conventi
> ons
> 
> Please review, particularly the Null and annotation sections.
> 
> I will do some additional research into the nullability annotations and
> propose further changes if warranted.
> 
> -- Scott
> 
> 
> --
> To unsubscribe from this list send an email to dev-
> unsubscribe at shibboleth.net