Action/profile refactoring

[Cantor, Scott]

On 4/12/13 11:04 AM, "Marvin S. Addison" <marvin.addison at gmail.com> wrote:
>
>Nice work on the refactor and documentation! I think this will meet the
>goal of decoupling from Spring where possible while maintaining a
>natural style in flow XML configuration. I do think there's a lingering
>question of naming/style to discuss and resolve. I think lowercase bean
>names and event ids are standard convention and I can't imagine any
>reason to depart from it. (I fully admit there may be an existing style
>guide for this that I'm not aware of.) In any case it seems worthy of
>discussion before writing much more code/configuration.

I have no perspective on that, so you should take any of my examples as
nothing but copying existing examples in the code base, and those are mock
ups as much as anything. I think I'm happy with the overall syntax, but
have no strong feelings about the bean names or events. (I think our
events are lower case, though?)

One leftover issue is whether to keep the more complex EventContext model
for returning events indirectly, or just use String and be done with it,
returning that from the ProfileAction.execute() method. The only reason I
didn't do that was that the buildEvent code we have now allows for
including the extensible map in the Event.

-- Scott