Action/profile refactoring

Cantor, Scott cantor.2 at osu.edu
Wed Apr 10 13:54:49 EDT 2013


Initial refactor is done. Once I see what tests are still failing I'll fix
those and then work on some documentation about how this is meant to be
organized.

The current action beans are all left in idp modules for now, but many of
them can move to opensaml modules once we deal with the @Event annotation
question.

We think that it's going to be impractical to generate usable javadoc from
those. I think we want to convert them to javadoc taglets, in which case
there won't be a package dependency on net.shibboleth.idp for the
annotations (or a conflict with Event from webflow) and I can refactor the
existing Spring-oblivious actions into opensaml at that point.

The way I have the code refactored:

- HttpServlet* is never passed as a parameter but accessed via
ProfileRequestContext
- All actions in the idp layer are now Spring-dependent deliberately
- Any actions that don't need to be Spring-dependent are candidates to
move and switch base classes to the Spring-oblivious version

A consequence of the refactoring is eliminating a lot of null parameters
in the unit test doExecute calls, which is a good sign IMHO that the
interface wasn't where it should be.

-- Scott




More information about the dev mailing list