Experiments with command-line and web flow adaptor

Cantor, Scott cantor.2 at osu.edu
Mon Apr 8 13:54:17 EDT 2013


On 4/8/13 1:11 PM, "Tom Zeller" <tzeller at dragonacea.biz> wrote:

>In other words, Action evaluate expressions should not contain special
>characters.

In the absence of a compelling benefit, I agree with that goal. What I was
doing was not a compelling enough benefit by itself, but since there's
already a syntax for POJOs and a system for mapping non-Event return
values into Events, the point of the adaptor really is just syntactic as
it turns out.

>This is me giving a green light, pending any other discussion or
>comments, to move forward with the Spring-neutral WebFlowAdaptor.

Ok. I think we're in general agreement that we'd want an
opensaml-profile-api module and friends, and that probably this is where
the non-messaging code from -messaging-api belongs. In fact, I think
BaseContext itself belongs there. MessagingContext, et al. are really just
specific subtypes and classes for messaging that would rely on
-profile-api.

I'm not sure that "Profile" is really the right word here, but I don't
have a better one at the moment, and right now all the Action code is
built around a "ProfileRequestContext" so it's already pretty baked in.

Anyway, I haven't done any module creating yet, but I can take a stab at
that so I learn how.

>Minor comments :
>
>I think that the javadoc for ProfileAction should talk about emulating
>a Spring Web Flow Action to obviate the need for Spring dependencies.

There's a fair bit needed on this, yes, and some of it may change
depending on how we want to handle the Events and the standardizing of all
that.

>I think that WebFlowAdaptor should possibly have the word "Action" in
>the name, maybe WebFlowActionAdaptor or WebFlowProfileActionAdaptor,
>to make it clear that it is an Action adaptor.

I left it out because of the standard we had of not putting Action in the
names, though I suppose this is a special sort of action.

>I like what you did, Scott.

Ok, good. The next step in this area will be to really look at how the
boilerplate in these actions should work.

-- Scott




More information about the dev mailing list