OpenSAML dependency on Velocity breaks application

[Tom van den Berge]

Hi Brent,

Unfortunately overriding initializeVelocity doesn't work since it is a
static method, so the only option seems to be to override bootstrap() and
leave out the initializeVelocity() method. Sadly, this also means that the
static String[] xmlToolingsConfigs must be copied.

I fully agree that initially, this is a Velocity problem, since it seems
that it can only be initializes in a static way. However the same is true
for OpenSAML, although there is a relatively simple workaround for it.


Thanks,
Tom


On Fri, Apr 27, 2012 at 9:02 PM, Brent Putman <putmanb at georgetown.edu>wrote:

>
>
> On 4/27/12 7:25 AM, Tom van den Berge wrote:
> >
> > I think it would be far better to have this optional in OpenSAML
> > itself though. Duplicating code is a major sin ;)
> >
>
> Note that you don't have to literally copy/duplicate code to do this.
> You can just extend the DefaultBootstrap class and override the
> initializeVelocity() method to be a no-op.  Then invoke that bootstrap
> subclass instead of ours.
>
> That said, I agree that it's not optimal for us to initialize Velocity
> like that.  We probably can't fix this for v2, since we aren't planning
> on anything but patch releases for that going forward.  But if you'd
> like to file a Jira issue against v3, we can examine whether we can
> rework how we use Velocity to avoid the static init.  It would actually
> be more crucial to fix it there, because the custom bootstrap workaround
> won't be there in v3, the library init there is very different.
>
> Thanks,
> Brent
>
>
>
> --
> To unsubscribe from this list send an email to
> dev-unsubscribe at shibboleth.net
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://shibboleth.net/pipermail/dev/attachments/20120501/a5feb51e/attachment.html