strange expiration-behaviour

[Leif Johansson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Not sure if this is the right place... We had some problems with
refresh of metadata and a friend noticed the following code-block
around line 238 of
ava-opensaml2/src/main/java/org/opensaml/saml2/metadata/provider/HTTPMetadataProvider.java
[1]

if (mdExpirationTime != null && !maintainExpiredMetadata() &&
mdExpirationTime.isBeforeNow()) {
   cachedMetadata = null;
} else {
   filterMetadata(metadata);
   releaseMetadataDOM(metadata);
   cachedMetadata = metadata;
}

Shouldn't that be mdExpirationTime.isAfterNow() ?

The effect we saw was that a DS was in a tight loop fetching metadata
with no explicit cacheDuration. It looked like it fetched metadata and
disgarded it immediately.

	Cheers Leif

[1]
http://svn.shibboleth.net/view/java-opensaml2/trunk/src/main/java/org/opensaml/saml2/metadata/provider/HTTPMetadataProvider.java?view=markup
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8gHDIACgkQ8Jx8FtbMZnezFwCgtf+86RcCQbEoZcpMUizMuuUs
xpQAoMa2Ewp347Zd1TQTWCJV0t39y8lA
=Noe5
-----END PGP SIGNATURE-----