Adding option to suppress NotBefore condition in assertions?

[Grady, Michael Allen]

Are there unit tests/integration tests/test cases for each of these options that should also be crafted/included when adding a new option such as this Relying Party one? I haven't yet looked closely at what does and doesn't exist as far as tests and QA.

On Dec 28, 2012, at 12:24 PM, Cantor, Scott wrote:

> On 12/28/12 1:20 PM, "William G. Thompson, Jr." <wgthom at gmail.com> wrote:
>> 
>> It's a "best use of time" issue as well as wanting to get some
>> assurance that the work will be acceptable to the Shib IdP committers.
> 
> I'm sorry if I wasn't clear originally. I have no objection to the patch.
> 
> The basic approach to adding a profile option is:
> 
> - add it to the profile handler schema in the appropriate element
> definition
> - implement it in the bean parsing logic that sets options on the profile
> handler config
> - implement the change in the profile handler
> 
> A comparable example is the includeAttributeStatement option.
> 
>> Unicon would prefer to apply our limited sustaining engineering
>> budget to the official distribution.
> 
> That I understand.
> 
> -- Scott
> 
> 
> --
> To unsubscribe from this list send an email to dev-unsubscribe at shibboleth.net

                      
--
Michael A. Grady                      
University of Illinois at Urbana-Champaign (retired)
217-721-3890