<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0"> <base href="https://shibboleth.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429;">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0;" bgcolor="#f5f5f5"><!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="border-collapse: collapse; padding: 10px 20px;">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0;">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px;" width="32"><img id="header-avatar-image" class="image_fix" src="https://avatar-management--avatars.us-west-2.prod.public.atl-paas.net/59fb32bbc24efb3c4ed3c977/a0c45ae9-ceeb-41b4-94a1-1eed64e25ae4/48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top;"></td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px;"><a class="user-hover" rel="59fb32bbc24efb3c4ed3c977" style="color: #3b73af; text-decoration: none;" id="email_59fb32bbc24efb3c4ed3c977" href="https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977"> Rod Widdowson </a> <strong>commented</strong> on <a href="https://shibboleth.atlassian.net/browse/IDP-2133?atlOrigin=eyJpIjoiMzQ2YTg5MjJlNWM5NDhhMmFhZTQ4ZGI2NzVjNTM1NDkiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none;"><img src="cid:jira-generated-image-avatar-b3d73530-8bce-416f-b514-2012f6436f3f" height="16" width="16" border="0" align="absmiddle" alt="Bug"> IDP-2133</a></td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td id="email-content-container" style="border-collapse: collapse; padding: 0 20px;">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate;">
<tbody>
<tr><!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="border-collapse: collapse; color: #ffffff; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly;" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff;" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0;">
<tbody>
<tr>
<td style="vertical-align: top; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly;" class="page-title-pattern-header-container"><span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle;"> <a href="https://shibboleth.atlassian.net/browse/IDP-2133?atlOrigin=eyJpIjoiMzQ2YTg5MjJlNWM5NDhhMmFhZTQ4ZGI2NzVjNTM1NDkiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none;">Re: seckeygen.sh not updated on upgrade to v5</a> </span></td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0;" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px;">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="border-collapse: collapse; padding: 0 0 10px;"><p style="margin: 10px 0 0; margin-top: 0;">I <em>think</em> that the fundamental issue is that we don’t have a way to add files to a module when it gets changed and this is going to bite us forever. For modules which come with plugins it may be a bit less of an issue because we tend to rename the module (correct?).</p> <p style="margin: 10px 0 0;">Is it too much to have a module.required property which can be used for current state detection? Or is that just optional by another name</p> <p style="margin: 10px 0 0;">Anyway what happens in the installer right now is that</p>
<ol>
<li>If this is a new install then idp.core is enabled</li>
<li>Stuff happens which need the core module - and specifically idp.properties</li>
<li>If this is an existing install then only those modules detected as enabled when we started are re-enabled.</li>
<li>If this is a new install then idp.EditWebApp, idp.CommandLine, idp.authn.Password, idp.admin.Hello are all enabled</li>
<li>But notably there isn’t a “If this is an update then this module must be installed” list. This is Scotts suggestion.</li>
</ol> <p style="margin: 10px 0 0;">It feels like the installer is the place to have the list of modules to force enable on update (i.e. stage 5), not the module itself. We could add this and populate it with idp.core, idp.EditWebApp, idp.CommandLine. But we are still going to die badly if another module (idp.authn.password, say) gets a new file, so maybe that's not such a good idea.</p> <p style="margin: 10px 0 0;">There is yet another idea (which scares me and I therefore detest, but we do this already for the plugins) is to get the <b>old</b> install to detect whether a module is enabled. We currently only run the installer with a classpath taken from the distro (so its the distro’s idea of what a module is that counts) but it would be possible to reach out into the existing install and map those jars into a separate ClasspathLoader and use that to ask about the modules, then we would use the old version to establish whether it was enabled. At that stage we have the “old enabled modules” and we can add the “new modules” if they are not in the module list (either disabled or enabled).</p> <p style="margin: 10px 0 0;"><span class="error">[I have no idea what this would mean for a module that changed when a plugin got updated (I have a feeling that the classpath there is also weird but I shudder at the idea of separating those ones out)]</span></p> <p style="margin: 10px 0 0;">Anyway that approach this would fix the V4->V5 issue (because IdP.CommandLine would not be found using the old classpath from the V4 install) but it would not fix the problem that Ian has (although his problem would also be fixable by hand enabling the IdP.CommandLine module.</p> <p style="margin: 10px 0 0;"><a href="https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8" class="user-hover" rel="557058:e127cb03-43ed-473d-b6ba-592949cb4be8" data-account-id="557058:e127cb03-43ed-473d-b6ba-592949cb4be8" accountid="557058:e127cb03-43ed-473d-b6ba-592949cb4be8" style="color: #3b73af; text-decoration: none;">Ian Young</a> I think that there are enough open questions here that it would be good if you can avoid doing another update until we know what we are going to do.</p> <p style="margin: 10px 0 0;">A final thought: we could help the diagnosis of this by changing the logging level in the module code so that if one file was found but another wasn’t this was a WARN and not a DEBUG.</p> <p style="margin: 10px 0 0;">Ugh! I’ll sleep on it and see what tomorrow brings. Right now I’m thinking that Scott’s “force it in the installer” combined with a change in logging is the way to go.</p></td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff;" bgcolor="#ffffff"><script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://shibboleth.atlassian.net/browse/IDP-2133?inbox=true&focusedCommentId=35208&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-35208",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px;">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0;">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0;">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle;"><a href="https://shibboleth.atlassian.net/browse/IDP-2133#add-comment?atlOrigin=eyJpIjoiMzQ2YTg5MjJlNWM5NDhhMmFhZTQ4ZGI2NzVjNTM1NDkiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none;"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-2834ba2f-93fd-409e-bf54-5878eb112828" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle;"> </a></td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px;"><a href="https://shibboleth.atlassian.net/browse/IDP-2133#add-comment?atlOrigin=eyJpIjoiMzQ2YTg5MjJlNWM5NDhhMmFhZTQ4ZGI2NzVjNTM1NDkiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none;">Add Comment</a></td>
</tr>
</tbody>
</table></td>
</tr>
</tbody>
</table></td>
</tr> <!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly;" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td id="footer-pattern" style="border-collapse: collapse; padding: 12px 20px;">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0;">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px;">Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none;">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none;">iOS</a>
<hr></td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px;">This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100227-<span title="6a5b8c4a331b2f147517227fefb7002793b864d8" data-commit-id="6a5b8c4a331b2f147517227fefb7002793b864d8}">sha1:6a5b8c4</span>)</span></td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top;">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0;">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150;"><img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-6f6bdcc4-4d60-4ca0-b3eb-dc4872ea692c" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"></td>
</tr>
</tbody>
</table></td>
</tr>
</tbody>
</table></td>
</tr>
</tbody>
</table>
</body>
</html>