<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://shibboleth.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5"><!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"><img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/6aa94a2fe8aafdf2bf8daa02251b6b55?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FTZ-6.png" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"></td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"><a class="user-hover" rel="557058:0fa99aa9-d698-454c-a274-7a41bee6cef5" style="color:#3b73af;; color: #3b73af; text-decoration: none" id="email_557058:0fa99aa9-d698-454c-a274-7a41bee6cef5" href="https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A0fa99aa9-d698-454c-a274-7a41bee6cef5"> Tom Zeller </a><strong>commented</strong> on <a href="https://shibboleth.atlassian.net/browse/JPAR-197?atlOrigin=eyJpIjoiZmQ5NjQ2NWZhYWNjNGQ3MjkxYjVjYTFkNDhlYjA4NTEiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-1279216f-6594-44c6-bc9d-161de24ef1ab" height="16" width="16" border="0" align="absmiddle" alt="Task"> JPAR-197</a></td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr><!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"><span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://shibboleth.atlassian.net/browse/JPAR-197?atlOrigin=eyJpIjoiZmQ5NjQ2NWZhYWNjNGQ3MjkxYjVjYTFkNDhlYjA4NTEiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Re: Remove our repositories from POMs</a> </span></td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"><p style="margin: 10px 0 0; margin-top: 0">Picking this back up again ...</p><p style="margin: 10px 0 0">Actually I think we should keep repositories in POMs but remove them at release.</p><p style="margin: 10px 0 0">Deployed release artifacts will have no repositories in POMs, which is the Maven "best practice" [1], and could be enforced using a built-in [2] Maven Enforcer rule.</p><p style="margin: 10px 0 0">Yes, one more detail to remember at release time.</p><p style="margin: 10px 0 0">Reason being expediency, e.g. the Spring Framework milestone repository.</p><p style="margin: 10px 0 0">Alternatives include :</p>
<ul>
<li>declare repositories in settings.xml</li>
<li>host third-party milestone/snapshots via Nexus/Apache</li>
<li>proxy using Nexus</li>
</ul><p style="margin: 10px 0 0">While declaring repositories in settings.xml has been our plan, it's a little more work to make changes on the CI nodes. Rather than declaring third-party snapshot/milestone repositories (e.g. Spring, Jetty, ldaptive) individually in settings.xml, I'd probably rather host them via a third-party repository in Nexus. At the moment, we would need to cut AMIs to change settings.xml, but we could automate using a script or git repository etc and restart agents when we make changes.</p><p style="margin: 10px 0 0">Maven 5 might introduce the notion of build and consumer POMs, so this (remove repos from non-snapshot POMs during deployment) would fit that pattern. [3]</p><p style="margin: 10px 0 0">The whole point is that release artifacts should only depend on Central (because sans-signature-cheching it's trivial to introduce supply/dependency-chain attacks since transitive/plugin/test dependencies inject their repositories into the runtime artifact resolution chain AIUI).</p>
<hr><p style="margin: 10px 0 0">[1] <a href="https://central.sonatype.org/publish/requirements/#a-complete-example-pom" class="external-link" rel="nofollow noreferrer" style="color: #3b73af; text-decoration: none">https://central.sonatype.org/publish/requirements/#a-complete-example-pom</a> </p><p style="margin: 10px 0 0">"we discourage the usage of <repositories> and <pluginRepositories> and instead publish any required components to the Central Repository. This applies for your own components as well as for 3rd party artifacts."</p><p style="margin: 10px 0 0">[2] <a href="https://maven.apache.org/enforcer/enforcer-rules/requireNoRepositories.html" class="external-link" rel="nofollow noreferrer" style="color: #3b73af; text-decoration: none">https://maven.apache.org/enforcer/enforcer-rules/requireNoRepositories.html</a> <br> <tt>mvn enforcer:enforce -Drules=requireNoRepositories</tt></p><p style="margin: 10px 0 0">[3] <a href="https://www.javaadvent.com/2021/12/from-maven-3-to-maven-5.html" class="external-link" rel="nofollow noreferrer" style="color: #3b73af; text-decoration: none">https://www.javaadvent.com/2021/12/from-maven-3-to-maven-5.html</a> </p>
<hr><p style="margin: 10px 0 0"><a href="https://maven.apache.org/guides/mini/guide-multiple-repositories.html" class="external-link" rel="nofollow noreferrer" style="color: #3b73af; text-decoration: none">https://maven.apache.org/guides/mini/guide-multiple-repositories.html</a> </p><p style="margin: 10px 0 0">Repository Order</p><p style="margin: 10px 0 0">Remote repository URLs are queried in the following order for artifacts until one returns a valid result:</p>
<div class="preformatted panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="preformattedContent panelContent" style="padding: 9px 12px">
<pre style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal; white-space: pre; word-break: normal; word-wrap: break-word; word-break: break-all; white-space: pre-wrap">effective settings:
Global settings.xml
User settings.xml
local effective build POM:
Local pom.xml
Parent POMs, recursively
Super POM
effective POMs from dependency path to the artifact.</pre>
</div>
</div><p style="margin: 10px 0 0">For each of these locations, the repositories within the profiles are queried first in the order outlined at Introduction to build profiles.</p><p style="margin: 10px 0 0">Before downloading from a repository, mirrors configuration is applied.</p><p style="margin: 10px 0 0">Effective settings and local build POM, with profile taken into account, can easily be reviewed to see their repositories order with mvn help:effective-settings and mvn help:effective-pom -Dverbose.</p></td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"><script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://shibboleth.atlassian.net/browse/JPAR-197?inbox=true&focusedCommentId=33456&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-33456",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"><a href="https://shibboleth.atlassian.net/browse/JPAR-197#add-comment?atlOrigin=eyJpIjoiZmQ5NjQ2NWZhYWNjNGQ3MjkxYjVjYTFkNDhlYjA4NTEiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-c40cfbbd-2379-449e-8233-ebb5d5c24466" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a></td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"><a href="https://shibboleth.atlassian.net/browse/JPAR-197#add-comment?atlOrigin=eyJpIjoiZmQ5NjQ2NWZhYWNjNGQ3MjkxYjVjYTFkNDhlYjA4NTEiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a></td>
</tr>
</tbody>
</table></td>
</tr>
</tbody>
</table></td>
</tr><!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table></td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr></td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100206-<span title="3fcec87e1489dbd5ba19c781935acefd577fcd94" data-commit-id="3fcec87e1489dbd5ba19c781935acefd577fcd94}">sha1:3fcec87</span>)</span></td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"><img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-9691b525-516b-471b-824f-c0763877fdca" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"></td>
</tr>
</tbody>
</table></td>
</tr>
</tbody>
</table></td>
</tr>
</tbody>
</table>
</body>
</html>