<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://shibboleth.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5"> <!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/167faa998823987c7bf0c77a91008340?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FIY-6.png" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="557058:e127cb03-43ed-473d-b6ba-592949cb4be8" style="color:#3b73af;; color: #3b73af; text-decoration: none" id="email_557058:e127cb03-43ed-473d-b6ba-592949cb4be8" href="https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8"> Ian Young </a> <strong>commented</strong> on <a href="https://shibboleth.atlassian.net/browse/JPAR-195?atlOrigin=eyJpIjoiNThhZWI4OWU0MDBhNDQwNGE0ZDlhMmEwZTUwN2M4NDkiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-a251fe6d-c3da-4f98-9ac9-2761506600f7" height="16" width="16" border="0" align="absmiddle" alt="Task"> JPAR-195</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr> <!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://shibboleth.atlassian.net/browse/JPAR-195?atlOrigin=eyJpIjoiNThhZWI4OWU0MDBhNDQwNGE0ZDlhMmEwZTUwN2M4NDkiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Re: Review and simplify release profile</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">The profile contains the following:</p>
<ul>
<li>It runs <tt>maven-source-plugin</tt> and <tt>maven-javadoc-plugin</tt>, which are pretty much useless except in a release context, so that's fine.</li>
<li>It runs <tt>maven-dependency-plugin</tt> as follows:</li>
</ul>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal"><span class="code-tag" style="color: #000091"><plugin></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.apache.maven.plugins<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>maven-dependency-plugin<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"></plugin></span></pre>
</div>
</div> <p style="margin: 10px 0 0">I don't think this actually does anything. If it <em>did</em> do something, it’s not clear to me that we’d only want to do it while performing a release. I think this can just be removed.</p>
<ul>
<li>It runs the <tt>maven-compiler-plugin</tt> as follows:</li>
</ul>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal"><span class="code-tag" style="color: #000091"><plugin></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.apache.maven.plugins<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>maven-compiler-plugin<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"><configuration></span>
<span class="code-tag" style="color: #000091"><showDeprecation></span>true<span class="code-tag" style="color: #000091"></showDeprecation></span>
<span class="code-tag" style="color: #000091"><showWarnings></span>true<span class="code-tag" style="color: #000091"></showWarnings></span>
<span class="code-tag" style="color: #000091"><debug></span>true<span class="code-tag" style="color: #000091"></debug></span>
<span class="code-tag" style="color: #000091"></configuration></span>
<span class="code-tag" style="color: #000091"></plugin></span></pre>
</div>
</div> <p style="margin: 10px 0 0">Of these:</p>
<ul>
<li><tt>showDeprecation</tt> defaults to <tt>false</tt>, so this does do something. It turns on deprecations <em>in the one circumstance – creating a release – when you almost certainly should not do anything with the information.</em> In my opinion, this is not related to releases and should not be in the release profile. I think it’s probably like this because someone didn’t want to see deprecations during normal development. I disagree: this should be put in the default profile and removed from “release”. In the alternative, there’s already a “lint” profile that includes this setting.</li>
<li><tt>showWarnings</tt> defaults to <tt>false</tt>, so again this does do something. Even more than deprecations, however, I’d argue that warnings should always be enabled and, again, I’d suggest moving this to the default profile.</li>
<li><tt>debug</tt> defaults to <tt>true</tt>, so this has no effect and can be removed (or moved to the default profile, where it would still have no effect). There’s in any case no argument that makes sense that we should have debug symbols disabled for development and enabled for release, so it’s presence in this context is clearly an error.</li>
</ul> <p style="margin: 10px 0 0">In summary, I think the <tt>maven-compiler-plugin</tt> settings should be moved to the default profile and this plugin deleted from the <tt>release</tt> profile.</p>
<ul>
<li>The <tt>release</tt> profile runs the <tt>maven-assembly-plugin</tt> as follows:</li>
<li>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal"><span class="code-tag" style="color: #000091"><plugin></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.apache.maven.plugins<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>maven-assembly-plugin<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"><configuration></span>
<span class="code-tag" style="color: #000091"><tarLongFileMode></span>gnu<span class="code-tag" style="color: #000091"></tarLongFileMode></span>
<span class="code-tag" style="color: #000091"><ignoreMissingDescriptor></span>true<span class="code-tag" style="color: #000091"></ignoreMissingDescriptor></span>
<span class="code-tag" style="color: #000091"></configuration></span>
<span class="code-tag" style="color: #000091"><executions></span>
<span class="code-tag" style="color: #000091"><execution></span>
<span class="code-tag" style="color: #000091"><id></span>make-assembly<span class="code-tag" style="color: #000091"></id></span>
<span class="code-tag" style="color: #000091"><phase></span>package<span class="code-tag" style="color: #000091"></phase></span>
<span class="code-tag" style="color: #000091"><goals></span>
<span class="code-tag" style="color: #000091"><goal></span>single<span class="code-tag" style="color: #000091"></goal></span>
<span class="code-tag" style="color: #000091"></goals></span>
<span class="code-tag" style="color: #000091"></execution></span>
<span class="code-tag" style="color: #000091"></executions></span>
<span class="code-tag" style="color: #000091"></plugin></span></pre>
</div>
</div></li>
</ul> <p style="margin: 10px 0 0">Although this seems at first glance to make sense as part of the “release” profile (because you only want the packaged <tt>.zip</tt> or <tt>.tar.gz</tt> files if you’re releasing them, there are two issues with this choice:</p>
<ul>
<li>With a couple of exceptions (the MDA and xmlsectool, whose build profiles are not very modern, to say the least, as I’ve tended to leave what Chad wrote unchanged as long as it works) I think every one of our projects that builds an assembly has its own configuration for it, overriding the above and building the assembly in the default profile.</li>
<li>One reason that may be true, which has particular relevance today, is that if you want to do anything with the assembly as part of packaging (e.g., to look inside it to validate something) you need the assembly to be built even when you’re not building “a release”.</li>
</ul> <p style="margin: 10px 0 0">I therefore propose that we remove this plugin from the <tt>release</tt> profile and either:</p>
<ul>
<li>Incorporate it in the default profile (neither of the configuration settings are default), or</li>
<li>Remove it entirely and rely in individual projects to do this themselves (as most of them do).</li>
</ul> <p style="margin: 10px 0 0">In both cases, we’d probably want to check that the <tt>tarLongFileMode</tt> setting was appropriate for each project (the default is to warn on file paths of more than 100 characters).</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://shibboleth.atlassian.net/browse/JPAR-195?inbox=true&focusedCommentId=31578&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-31578",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://shibboleth.atlassian.net/browse/JPAR-195#add-comment?atlOrigin=eyJpIjoiNThhZWI4OWU0MDBhNDQwNGE0ZDlhMmEwZTUwN2M4NDkiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-63d402a6-ceda-4d77-9cca-615a14cbcd35" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://shibboleth.atlassian.net/browse/JPAR-195#add-comment?atlOrigin=eyJpIjoiNThhZWI4OWU0MDBhNDQwNGE0ZDlhMmEwZTUwN2M4NDkiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr> <!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100183-<span title="8e458bc4d5b888255ca1b3736ab84e4e080985ac" data-commit-id="8e458bc4d5b888255ca1b3736ab84e4e080985ac}">sha1:8e458bc</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5ea1ec09-52d5-4c22-bad2-73b2e293fa8d" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>