<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.shibboleth.net/jira">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-957124f7-1d7c-4b16-b3ab-038016dc38fe" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="rnf3t5gm5dhhsr0aulzvjsung7a=@https://lmuidp.lrz.de/idp/shibboleth" id="email_rnf3t5gm5dhhsr0aulzvjsung7a=@https://lmuidp.lrz.de/idp/shibboleth" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=rnf3t5gm5dhhsr0aulzvjsung7a%3D%40https%3A%2F%2Flmuidp.lrz.de%2Fidp%2Fshibboleth" style="color:#0052cc;; color: #3b73af; text-decoration: none">rnf3t5gm5dhhsr0aulzvjsung7a=@https://lmuidp.lrz.de/idp/shibboleth</a> <strong>created</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://issues.shibboleth.net/jira/browse/IDP" style="color: #3b73af; text-decoration: none">Identity Provider</a> / <a href="https://issues.shibboleth.net/jira/browse/IDP-1790" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-4af012ef-4411-4266-81c0-0dc8dc3e4bde" height="16" width="16" border="0" align="absmiddle" alt="Improvement" style="vertical-align: text-bottom"></a> <a href="https://issues.shibboleth.net/jira/browse/IDP-1790" style="color: #3b73af; text-decoration: none">IDP-1790</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1790" style="color: #3b73af; text-decoration: none">Classpath resources should not be accessed by filesystem paths</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Issue Type:</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-4af012ef-4411-4266-81c0-0dc8dc3e4bde" height="16" width="16" border="0" align="absmiddle" alt="Improvement" style="vertical-align: text-bottom"> Improvement </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Affects Versions:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 4.1.0 </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Assignee:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="tzeller@shibboleth.net" id="email_tzeller@shibboleth.net" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=tzeller%40shibboleth.net" style="color:#0052cc;; color: #3b73af; text-decoration: none">Tom Zeller</a> </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Components:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> User Interface </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Created:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 07/Apr/21 4:36 PM </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Environment:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0; margin-top: 0">CentOS 8</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">OpenJDK 11</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Wildfly 22.0.1.Final</p> </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Labels:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> velocity </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Priority:</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-minor-1bcf7fc5-3421-4683-bfff-22a721a7889e" height="16" width="16" border="0" align="absmiddle" alt="Minor" style="vertical-align: text-bottom"> Minor </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Reporter:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="rnf3t5gm5dhhsr0aulzvjsung7a=@https://lmuidp.lrz.de/idp/shibboleth" id="email_rnf3t5gm5dhhsr0aulzvjsung7a=@https://lmuidp.lrz.de/idp/shibboleth" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=rnf3t5gm5dhhsr0aulzvjsung7a%3D%40https%3A%2F%2Flmuidp.lrz.de%2Fidp%2Fshibboleth" style="color:#0052cc;; color: #3b73af; text-decoration: none">rnf3t5gm5dhhsr0aulzvjsung7a=@https://lmuidp.lrz.de/idp/shibboleth</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0; margin-top: 0">Hello,</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">I have found a wildfly compatibility issue with version 4.1.0. While I know that wildfly is not supported and everything seems to work just fine on jetty (and propably tomcat too), I think this issue might cause problems on supported platforms in the future.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">So, in 4.1.0, the "system" files have been moved into idp-conf-impl-4.1.0.jar as is stated in the release notes.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Now wildfly is unable to load them:</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><tt>2021-04-07 16:05:23,705 - 172.16.0.1 - ERROR <span class="error">[org.apache.velocity.loader:351]</span> - ResourceManager: unable to find resource 'client-storage/local-storage-read.js' in any resource loader.</tt><br> <tt>2021-04-07 16:05:23,706 - 172.16.0.1 - ERROR <span class="error">[org.apache.velocity.directive.include:245]</span> - #include(): cannot find resource 'client-storage/local-storage-read.js', called at /client-storage/client-storage-read.vm<span class="error">[line 26, column 9]</span></tt><br> <tt>2021-04-07 16:05:23,707 - 172.16.0.1 - ERROR <span class="error">[net.shibboleth.idp.profile:-2]</span> - Uncaught runtime exception</tt><br> <tt>java.lang.IllegalStateException: Exception occurred rendering view net.shibboleth.ext.spring.velocity.VelocityView: name '/client-storage/client-storage-read'; URL <span class="error">[/client-storage/client-storage-read.vm]</span></tt><br> {{ at deployment.login.war//org.springframework.webflow.mvc.view.AbstractMvcView.render(AbstractMvcView.java:208)}}<br> <tt>Caused by: org.apache.velocity.exception.ResourceNotFoundException: Unable to find resource 'client-storage/local-storage-read.js'</tt><br> {{ at deployment.login.war//org.apache.velocity.runtime.resource.ResourceManagerImpl.loadResource(ResourceManagerImpl.java:461)}}</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">The reason seems to be this:</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><tt>2021-04-07 14:49:17,008 - - DEBUG <span class="error">[net.shibboleth.ext.spring.velocity.VelocityEngineFactory:321]</span> - Resource loader path 'classpath:/net/shibboleth/idp/views' resolved to file '/opt/wildfly_base/tmp/vfs/deployment/deployment36580d67cdade32c/idp-conf-impl-4.1.0.jar-e7c5347820a4d3d7/contents/net/shibboleth/idp/views'</tt></p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">"classpath:/net/shibboleth/idp/views" has actually been resolved to a path in the file system where apparently wildfly has unpacked the idp-conf-impl-4.1.0.jar. But only partially, most of the files are missing (i.e. client-storage/local-storage-read.js). I'm not sure if wildfly is to blame here. I guess the wildfly folks did not expect someone to access classpath resources via a file system path. And I suspect you did not expect the jar files inside the war to be unpacked.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Compare the same situation on Jetty:</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">{{2021-04-07 14:57:12,183 - - DEBUG <span class="error">[net.shibboleth.ext.spring.velocity.VelocityEngineFactory:326]</span> - Cannot resolve resource loader path 'classpath:/net/shibboleth/idp/views' to filesystem, will use SpringResourceLoader<br> }}</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Things seem to go wrong here: <a href="https://git.shibboleth.net/view/?p=spring-extensions.git;a=blob;f=src/main/java/net/shibboleth/ext/spring/velocity/VelocityEngineFactory.java;hb=65dc4c3ae3548e75098596f555973b6811a3cf01#l318" class="external-link" target="_blank" rel="nofollow noopener" style="color: #3b73af; text-decoration: none">https://git.shibboleth.net/view/?p=spring-extensions.git;a=blob;f=src/main/java/net/shibboleth/ext/spring/velocity/VelocityEngineFactory.java;hb=65dc4c3ae3548e75098596f555973b6811a3cf01#l318</a></p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">This check<br> {{ // Will fail if not resolvable in the file system.<br> final File file = resource.getFile();<br> }}</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Does not (necessarily) fail on wildfly for classpath:// resources. So I guess the paths should be filtered so that classpath:// paths would never be accessed via the file system.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Maybe Spring is to blame here. I really see no point in accessing classpath resources via the file system. It might be more efficient but this kind of efficiency should be left to the runtime environment entirely. I suspect this is what wildfly is trying to accomplish.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Sorry to bother you. I know that, by using an unsupported platform, I'm on my own. It still might be interesting.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1790#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-42b13955-5948-4d82-aec3-492451224dcc" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1790#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v8.5.4#805004-<span title="0444eab799707f9ad7b248d69f858774aadfd250" data-commit-id="0444eab799707f9ad7b248d69f858774aadfd250}">sha1:0444eab</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.shibboleth.net/jira/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>