<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.shibboleth.net/jira">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-3c2feddc-61e1-49c5-88fd-56771fb27142" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="ian@iay.org.uk" id="email_ian@iay.org.uk" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=ian%40iay.org.uk" style="color:#0052cc;; color: #3b73af; text-decoration: none">Ian Young</a> <strong>commented</strong> on <a href="https://issues.shibboleth.net/jira/browse/IDP-1465" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-fc73c407-2016-40c9-b921-fdd5a55a0dda" height="16" width="16" border="0" align="absmiddle" alt="Task"> IDP-1465</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1465" style="color: #3b73af; text-decoration: none">Re: deep review of dependencies for v4</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <p style="margin: 10px 0 0 0; margin-top: 0">Ad mentioned in <a href="https://issues.shibboleth.net/jira/browse/JPAR-139" title="Multiple copies of Javabeans Activation Framework" class="issue-link" data-issue-key="JPAR-139" style="color: #3b73af; text-decoration: none">JPAR-139</a>, one thing that we still need to sort out is the split packages introduced by the unusual way the J2EE (now Jakarta EE) modules are implemented.</p> <p style="margin: 10px 0 0 0">Specifically for Java Activation:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
javax.activation
27 file:/activation-1.1.1.jar
31 file:/jakarta.activation-api-1.2.1.jar
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">It's clear that this is one example of a general pattern, where:</p>
<ul>
<li>Originally, there was a single artifact called (in this case) <tt>javax.activation:activation</tt>, containing both the API and the implementation.</li>
<li>The API and implementation are not separable here. They each depend on the other. They can't, therefore, be split into two artifacts.</li>
<li>To provide encapsulation pre-module system, <em>current</em> artifacts are:
<ul>
<li><tt>com.sun.activation:jakarta.activation</tt> is the implementation artifact, containing both API and implementation packages as before. The intention is that this is used at runtime.</li>
<li><tt>javax.activation:javax.activation-api</tt> contains <em>just</em> the API classes (perhaps a different expression of the API that doesn't depend on the implementation, I don't know). The intention is that this is used at compile time and <em>never</em> included at runtime.</li>
</ul> </li>
</ul> <p style="margin: 10px 0 0 0">This pattern seems to be repeated for Activation, Mail and JAXB in particular, but probably other modules as well.</p> <p style="margin: 10px 0 0 0">We need to:</p>
<ul>
<li>Stop managing the original artifact in the parent POM</li>
<li>Exclude any references to the API artifacts from modules having them as compile-time dependencies (unless they have been managed to "optional"</li>
<li>Ensure that the <em>implementation</em> artifacts are included at runtime</li>
<li>Enforce that the <em>API-only</em> artifacts are <em>not</em> included at runtime</li>
<li>Run <tt>jpkgsplitscan</tt> on products to make sure they don't have split packages because of this setup: they might not work at runtime, depending on which of the two implementations of the API packages "wins", which I don't think is guaranteed.</li>
<li>All of the above, for all affected modules.</li>
</ul> <p style="margin: 10px 0 0 0">Here's what we had a couple of months ago:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
javax.activation
27 file:/activation-1.1.1.jar
31 file:/jakarta.activation-api-1.2.1.jar
31 file:/javax.activation-api-1.2.0.jar
javax.json
19 file:/javax.json-1.0.4.jar
19 file:/javax.json-api-1.0.jar
javax.json.spi
1 file:/javax.json-1.0.4.jar
1 file:/javax.json-api-1.0.jar
javax.json.stream
8 file:/javax.json-1.0.4.jar
8 file:/javax.json-api-1.0.jar
javax.xml.bind
47 file:/jakarta.xml.bind-api-2.3.2.jar
47 file:/jaxb-api-2.3.1.jar
javax.xml.bind.annotation
40 file:/jakarta.xml.bind-api-2.3.2.jar
40 file:/jaxb-api-2.3.1.jar
javax.xml.bind.annotation.adapters
7 file:/jakarta.xml.bind-api-2.3.2.jar
7 file:/jaxb-api-2.3.1.jar
javax.xml.bind.attachment
2 file:/jakarta.xml.bind-api-2.3.2.jar
2 file:/jaxb-api-2.3.1.jar
javax.xml.bind.helpers
9 file:/jakarta.xml.bind-api-2.3.2.jar
9 file:/jaxb-api-2.3.1.jar
javax.xml.bind.util
5 file:/jakarta.xml.bind-api-2.3.2.jar
5 file:/jaxb-api-2.3.1.jar</pre>
</div>
</div> <p style="margin: 10px 0 0 0">The good news is that the initial work I did in <a href="https://issues.shibboleth.net/jira/browse/JPAR-139" title="Multiple copies of Javabeans Activation Framework" class="issue-link" data-issue-key="JPAR-139" style="color: #3b73af; text-decoration: none">JPAR-139</a> reduced that to this today:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
javax.activation
27 file:/activation-1.1.1.jar
31 file:/jakarta.activation-api-1.2.1.jar
javax.json
19 file:/javax.json-1.0.4.jar
19 file:/javax.json-api-1.0.jar
javax.json.spi
1 file:/javax.json-1.0.4.jar
1 file:/javax.json-api-1.0.jar
javax.json.stream
8 file:/javax.json-1.0.4.jar
8 file:/javax.json-api-1.0.jar
javax.xml.bind
47 file:/jakarta.xml.bind-api-2.3.2.jar
47 file:/jaxb-api-2.3.1.jar
javax.xml.bind.annotation
40 file:/jakarta.xml.bind-api-2.3.2.jar
40 file:/jaxb-api-2.3.1.jar
javax.xml.bind.annotation.adapters
7 file:/jakarta.xml.bind-api-2.3.2.jar
7 file:/jaxb-api-2.3.1.jar
javax.xml.bind.attachment
2 file:/jakarta.xml.bind-api-2.3.2.jar
2 file:/jaxb-api-2.3.1.jar
javax.xml.bind.helpers
9 file:/jakarta.xml.bind-api-2.3.2.jar
9 file:/jaxb-api-2.3.1.jar
javax.xml.bind.util
5 file:/jakarta.xml.bind-api-2.3.2.jar
5 file:/jaxb-api-2.3.1.jar</pre>
</div>
</div> <p style="margin: 10px 0 0 0">(We now have two, rather than three, artifacts clashing over <tt>javax.activation</tt>.</p> <p style="margin: 10px 0 0 0">I note that this is <em>before</em> correctly managing the Java Mail dependency, so the bad news is that it's actually worse than the above.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1465#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-8016fc9d-62ab-488d-a84d-5e7588c97879" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1465#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v8.5.1#805001-<span title="c5b54a7317f297e17ddad5bb52a1850cf2bdb4bc" data-commit-id="c5b54a7317f297e17ddad5bb52a1850cf2bdb4bc}">sha1:c5b54a7</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.shibboleth.net/jira/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>