<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.shibboleth.net/jira">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-6125b3fc-0f16-4365-b536-ad251dfa653e" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="rdw@iay.org.uk" id="email_rdw@iay.org.uk" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=rdw%40iay.org.uk" style="color:#0052cc;; color: #3b73af; text-decoration: none">Rod Widdowson</a> <strong>commented</strong> on <a href="https://issues.shibboleth.net/jira/browse/IDP-1181" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-de7e360d-88ef-443b-9542-ed3f36aab987" height="16" width="16" border="0" align="absmiddle" alt="Bug"> IDP-1181</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1181" style="color: #3b73af; text-decoration: none">Re: Rationalize fail-fast behavior in resolver</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <h2 style="margin: 10px 0 0 0; margin-top: 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0; margin-top: 0"><a name="Generalchanges" style="color: #3b73af; text-decoration: none"></a>General changes</h2> <p style="margin: 10px 0 0 0">I have made the following changes</p>
<ul>
<li>Mark the <tt>idp.initialize.failfast</tt> property as for tests only</li>
<li>Deprecate failFast for StoredID dataconnector and replace with failFastInitialize</li>
<li>failFast becomes failFastInitialize for all data connectors</li>
<li>Fix a bug in some refactoring (of mine) which would make all LDAP failures fast under all circumstances</li>
<li>Deprecate failFastInitialize on ConnectionPool</li>
</ul> <p style="margin: 10px 0 0 0">This last is because it doesn't do enough work.</p> <h2 style="margin: 10px 0 0 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0"><a name="Testing" style="color: #3b73af; text-decoration: none"></a>Testing</h2> <p style="margin: 10px 0 0 0">I ran a series of tests for LDAP</p>
<ul>
<li>Try a configuration with no server started</li>
<li>If we get a resolver at the end then try to resolve and note the failure</li>
<li>start an LDAP and resole -not that it works</li>
</ul> <p style="margin: 10px 0 0 0">I tried this for the 4 variants of failFastInitialize (Boolean setting in two places</p> <p style="margin: 10px 0 0 0">Under these conditions I determined that the failFastInitialize attribute on ConnectionPool is not sufficient</p>
<ul>
<li>The behavior of the system was controlled only by the DataConnector failfast.</li>
<li>This is because inability to connect inside LDAPtive always results in a PoolExhaustedEcxception (regardless of any configuration)</li>
</ul> <p style="margin: 10px 0 0 0">The details :</p> <h3 style="margin: 10px 0 0 0; font-size: 16px; line-height: 1.563; margin: 30px 0 0 0"><a name="DataConnectorfailFastInitialize%3DFALSEConnectionfailFastInitialize%3DFALSE" style="color: #3b73af; text-decoration: none"></a>DataConnector failFastInitialize=FALSE Connection failFastInitialize=FALSE</h3>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
ERROR [org.ldaptive.pool.BlockingConnectionPool:509] - [] unable to connect to the ldap
org.ldaptive.provider.ConnectionException: javax.naming.CommunicationException: localhost:20389 [Root exception is java.net.ConnectException: Connection refused: connect]
at org.ldaptive.provider.jndi.JndiConnectionFactory.createInternal(JndiConnectionFactory.java:104)
at org.ldaptive.provider.jndi.JndiConnectionFactory.createInternal(JndiConnectionFactory.java:33)
Caused by: javax.naming.CommunicationException: localhost:20389
at java.naming/com.sun.jndi.ldap.Connection.<init>(Connection.java:237)
at java.naming/com.sun.jndi.ldap.LdapClient.<init>(LdapClient.java:137)
Caused by: java.net.ConnectException: Connection refused: connect
at java.base/java.net.PlainSocketImpl.waitForConnect(Native Method)
at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:107)
WARN [org.ldaptive.pool.BlockingConnectionPool:600] - unable to create active connection
ERROR [org.ldaptive.pool.BlockingConnectionPool:197] - Could not service check out request
ERROR [net.shibboleth.idp.attribute.resolver.dc.ldap.impl.ConnectionFactoryValidator:108] - Connection factory validation failed
org.ldaptive.pool.PoolExhaustedException: Pool is empty and connection creation failed
at org.ldaptive.pool.BlockingConnectionPool.getConnection(BlockingConnectionPool.java:198)
at org.ldaptive.pool.PooledConnectionFactory.getConnection(PooledConnectionFactory.java:82)
ERROR [org.ldaptive.pool.BlockingConnectionPool:509] - [] unable to connect to the ldap
org.ldaptive.provider.ConnectionException: javax.naming.CommunicationException: localhost:20389 [Root exception is java.net.ConnectException: Connection refused: connect]
at org.ldaptive.provider.jndi.JndiConnectionFactory.createInternal(JndiConnectionFactory.java:104)
at org.ldaptive.provider.jndi.JndiConnectionFactory.createInternal(JndiConnectionFactory.java:33)
Caused by: javax.naming.CommunicationException: localhost:20389
at java.naming/com.sun.jndi.ldap.Connection.<init>(Connection.java:237)
at java.naming/com.sun.jndi.ldap.LdapClient.<init>(LdapClient.java:137)
Caused by: java.net.ConnectException: Connection refused: connect
at java.base/java.net.PlainSocketImpl.waitForConnect(Native Method)
at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:107)
WARN [org.ldaptive.pool.BlockingConnectionPool:600] - unable to create active connection
ERROR [org.ldaptive.pool.BlockingConnectionPool:197] - Could not service check out request
ERROR [net.shibboleth.idp.attribute.resolver.dc.ldap.impl.LDAPDataConnector:188] - Data Connector <span class="code-quote" style="color: #009100">'dataConnector'</span>: Failed to inspect SLL implementation
org.ldaptive.pool.PoolExhaustedException: Pool is empty and connection creation failed
at org.ldaptive.pool.BlockingConnectionPool.getConnection(BlockingConnectionPool.java:198)
at org.ldaptive.pool.PooledConnectionFactory.getConnection(PooledConnectionFactory.java:82)
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">Resolve after LDAP is started succeeds.</p> <h3 style="margin: 10px 0 0 0; font-size: 16px; line-height: 1.563; margin: 30px 0 0 0"><a name="DataConnectorfailFastInitialize%3DFALSEConnectionfailFastInitialize%3DTRUE" style="color: #3b73af; text-decoration: none"></a>DataConnector failFastInitialize=FALSE Connection failFastInitialize=TRUE</h3> <p style="margin: 10px 0 0 0">SAME LOG - this is because LDAPTIVE throws a PoolExhaustedEcxception withut regard to the failfast flag</p> <p style="margin: 10px 0 0 0">Resolve after LDAP is started succeeds.</p> <h3 style="margin: 10px 0 0 0; font-size: 16px; line-height: 1.563; margin: 30px 0 0 0"><a name="DataConnectorfailFastInitialize%3DTRUEConnectionfailFastInitialize%3DTRUE" style="color: #3b73af; text-decoration: none"></a>DataConnector failFastInitialize=TRUE Connection failFastInitialize=TRUE</h3> <p style="margin: 10px 0 0 0">DATA CONNECTOR TRUE<br> Connection TRUE</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
ERROR [org.ldaptive.pool.BlockingConnectionPool:509] - [] unable to connect to the ldap
org.ldaptive.provider.ConnectionException: javax.naming.CommunicationException: localhost:20389 [Root exception is java.net.ConnectException: Connection refused: connect]
at org.ldaptive.provider.jndi.JndiConnectionFactory.createInternal(JndiConnectionFactory.java:104)
at org.ldaptive.provider.jndi.JndiConnectionFactory.createInternal(JndiConnectionFactory.java:33)
Caused by: javax.naming.CommunicationException: localhost:20389
at java.naming/com.sun.jndi.ldap.Connection.<init>(Connection.java:237)
at java.naming/com.sun.jndi.ldap.LdapClient.<init>(LdapClient.java:137)
Caused by: java.net.ConnectException: Connection refused: connect
at java.base/java.net.PlainSocketImpl.waitForConnect(Native Method)
at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:107)
WARN [org.ldaptive.pool.BlockingConnectionPool:600] - unable to create active connection
ERROR [org.ldaptive.pool.BlockingConnectionPool:197] - Could not service check out request
ERROR [net.shibboleth.idp.attribute.resolver.dc.ldap.impl.ConnectionFactoryValidator:108] - Connection factory validation failed
org.ldaptive.pool.PoolExhaustedException: Pool is empty and connection creation failed
at org.ldaptive.pool.BlockingConnectionPool.getConnection(BlockingConnectionPool.java:198)
at org.ldaptive.pool.PooledConnectionFactory.getConnection(PooledConnectionFactory.java:82)
ERROR [net.shibboleth.idp.attribute.resolver.dc.ldap.impl.LDAPDataConnector:151] - Data Connector <span class="code-quote" style="color: #009100">'dataConnector'</span>: Invalid connector configuration
net.shibboleth.idp.attribute.resolver.dc.ValidationException: []
at net.shibboleth.idp.attribute.resolver.dc.ldap.impl.ConnectionFactoryValidator.validate(ConnectionFactoryValidator.java:110)
at net.shibboleth.idp.attribute.resolver.dc.ldap.impl.LDAPDataConnector.doInitialize(LDAPDataConnector.java:149)
Caused by: org.ldaptive.pool.PoolExhaustedException: Pool is empty and connection creation failed
at org.ldaptive.pool.BlockingConnectionPool.getConnection(BlockingConnectionPool.java:198)
at org.ldaptive.pool.PooledConnectionFactory.getConnection(PooledConnectionFactory.java:82)
ERROR [net.shibboleth.utilities.java.support.service.AbstractReloadableService:182] - Service <span class="code-quote" style="color: #009100">'shibboleth.AttributeResolverService'</span>: Initial load failed
net.shibboleth.utilities.java.support.service.ServiceException: Failed to load [file [H:\Perforce\Juno\New\java-identity-provider\idp-attribute-resolver-spring\target\test-classes\net\shibboleth\idp\attribute\resolver\failfast\attributeResolverLDAP.xml]]
at net.shibboleth.ext.spring.service.ReloadableSpringService.doReload(ReloadableSpringService.java:388)
at net.shibboleth.utilities.java.support.service.AbstractReloadableService.doInitialize(AbstractReloadableService.java:176)
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name <span class="code-quote" style="color: #009100">'dataConnector'</span>: Invocation of init method failed; nested exception is net.shibboleth.utilities.java.support.component.ComponentInitializationException: Data Connector <span class="code-quote" style="color: #009100">'dataConnector'</span>: Invalid connector configuration
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1778)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:593)
Caused by: net.shibboleth.utilities.java.support.component.ComponentInitializationException: Data Connector <span class="code-quote" style="color: #009100">'dataConnector'</span>: Invalid connector configuration
at net.shibboleth.idp.attribute.resolver.dc.ldap.impl.LDAPDataConnector.doInitialize(LDAPDataConnector.java:154)
at net.shibboleth.utilities.java.support.component.AbstractInitializableComponent.initialize(AbstractInitializableComponent.java:61)
Caused by: net.shibboleth.idp.attribute.resolver.dc.ValidationException: [org.ldaptive.pool.PoolExhaustedException@935599808::resultCode=<span class="code-keyword" style="color: #000091">null</span>, matchedDn=<span class="code-keyword" style="color: #000091">null</span>, responseControls=<span class="code-keyword" style="color: #000091">null</span>, referralURLs=<span class="code-keyword" style="color: #000091">null</span>, messageId=-1, message=Pool is empty and connection creation failed, providerException=<span class="code-keyword" style="color: #000091">null</span>]
at net.shibboleth.idp.attribute.resolver.dc.ldap.impl.ConnectionFactoryValidator.validate(ConnectionFactoryValidator.java:110)
at net.shibboleth.idp.attribute.resolver.dc.ldap.impl.LDAPDataConnector.doInitialize(LDAPDataConnector.java:149)
Caused by: org.ldaptive.pool.PoolExhaustedException: Pool is empty and connection creation failed
at org.ldaptive.pool.BlockingConnectionPool.getConnection(BlockingConnectionPool.java:198)
at org.ldaptive.pool.PooledConnectionFactory.getConnection(PooledConnectionFactory.java:82)
ERROR [net.shibboleth.utilities.java.support.service.AbstractReloadableService:185] - Service <span class="code-quote" style="color: #009100">'shibboleth.AttributeResolverService'</span>: No further attempts will be made to reload
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">No AR, so no progress.</p> <h3 style="margin: 10px 0 0 0; font-size: 16px; line-height: 1.563; margin: 30px 0 0 0"><a name="DataConnectorfailFastInitialize%3DTRUEConnectionfailFastInitialize%3DFALSE" style="color: #3b73af; text-decoration: none"></a>DataConnector failFastInitialize=TRUE Connection failFastInitialize=FALSE</h3> <p style="margin: 10px 0 0 0">Same results.</p> <h2 style="margin: 10px 0 0 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0"><a name="Workleft" style="color: #3b73af; text-decoration: none"></a>Work left</h2> <p style="margin: 10px 0 0 0">Review the failfast cases</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1181#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-c3dff679-774e-4902-83f8-d540531caf61" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1181#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v8.4.1#804002-<span title="94e96d6294939fc41f873484cf96b18ab6f2be0a" data-commit-id="94e96d6294939fc41f873484cf96b18ab6f2be0a}">sha1:94e96d6</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.shibboleth.net/jira/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>