<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://issues.shibboleth.net/jira" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-256bf71b-2dd5-4c18-a6ab-14fa714ad464" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="xxlfzgt2ayre+1i+clxa6irw1q4=@https://idp.cardiff.ac.uk/shibboleth" id="email_xxlfzgt2ayre+1i+clxa6irw1q4=@https://idp.cardiff.ac.uk/shibboleth" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=xxlfzgt2ayre%2B1i%2Bclxa6irw1q4%3D%40https%3A%2F%2Fidp.cardiff.ac.uk%2Fshibboleth" style="color:#3b73af;; color: #3b73af; text-decoration: none">xxlfzgt2ayre+1i+clxa6irw1q4=@https://idp.cardiff.ac.uk/shibboleth</a> <strong>created</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://issues.shibboleth.net/jira/browse/IDP" style="color: #3b73af; text-decoration: none">Identity Provider</a> / <a href="https://issues.shibboleth.net/jira/browse/IDP-1131" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-0ad70bc2-5e35-47f9-beec-4ad933056a19" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://issues.shibboleth.net/jira/browse/IDP-1131" style="color: #3b73af; text-decoration: none">IDP-1131</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1131" style="color: #3b73af; text-decoration: none">SubjectDerivedAttribute attribute definition causing null pointer exception when no matching attributeId found</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Issue Type:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-0ad70bc2-5e35-47f9-beec-4ad933056a19" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /> Bug
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Affects Versions:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
3.3.0
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Assignee:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="rdw@iay.org.uk" id="email_rdw@iay.org.uk" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=rdw%40iay.org.uk" style="color:#3b73af;; color: #3b73af; text-decoration: none">Rod Widdowson</a>
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Components:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
Attribute Resolver
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Created:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
02/Mar/17 10:03 AM
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Labels:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
SubjectDerivedAttribute
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Priority:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-minor-03ff3244-491a-4b9e-9b33-862c771a29b5" height="16" width="16" border="0" align="absmiddle" alt="Minor" style="vertical-align: text-bottom" /> Minor
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Reporter:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="xxlfzgt2ayre+1i+clxa6irw1q4=@https://idp.cardiff.ac.uk/shibboleth" id="email_xxlfzgt2ayre+1i+clxa6irw1q4=@https://idp.cardiff.ac.uk/shibboleth" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=xxlfzgt2ayre%2B1i%2Bclxa6irw1q4%3D%40https%3A%2F%2Fidp.cardiff.ac.uk%2Fshibboleth" style="color:#3b73af;; color: #3b73af; text-decoration: none">xxlfzgt2ayre+1i+clxa6irw1q4=@https://idp.cardiff.ac.uk/shibboleth</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Hello,</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">I am trying to use a SubjectDerivedAttribute attribute definition in my attribute-resolver (Shib Idp v3.3.0) to return IdPAttributes contained within IdPAttributePrincipals. These are placed into the Subject’s principals when authenticating the principal inside a custom JAAS login module.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">However, if the principalAttributeName can not be found (so there is no IdPAttribute with the same attributeId) I get a null pointer exception from the ContextDerivedAttributeDefinition e.g:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
2017-03-01 14:17:09,972 - INFO [net.shibboleth.idp.attribute.resolver.ad.impl.ContextDerivedAttributeDefinition:107] - SubjectDerivedAttributeDefinitionsomeattribute generated no values, attrribute no resolved.
2017-03-01 14:17:09,975 - ERROR [net.shibboleth.idp.profile:-2] - Uncaught runtime exception
java.lang.NullPointerException: <span class="code-keyword" style="color: #000091">null</span>
at net.shibboleth.idp.attribute.resolver.ad.impl.ContextDerivedAttributeDefinition.doAttributeDefinitionResolve(ContextDerivedAttributeDefinition.java:98)
2017-03-01 14:17:09,996 - WARN [org.opensaml.profile.action.impl.LogEvent:105] - A non-proceed event occurred <span class="code-keyword" style="color: #000091">while</span> processing the request: RuntimeException
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">This (as the msg says) prevents further events from occurring. </p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">It is a valid state in our Identity System that some principals do not contain every SubjectDerivedAttribute defined in the resolver. Hence, this prevents some of them from authenticating. </p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">It looks to me from the stack trace (but I maybe wrong), that this is due to a debug statement in the ContextDerivedAttributeDefinition.doAttributeDefinitionResolve, which calls the size() method of the results object without first checking the results object is not null. It also appears that the net/shibboleth/idp/attribute/resolver/ad/impl/SubjectDerivedAttributeValuesFunction.class legally allows null values to return from the apply method - so perhaps should be dealt with. </p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">I include the relevant code fragments even though I am sure you can easily look this up:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
net/shibboleth/idp/attribute/resolver/ad/impl/ContextDerivedAttributeDefinition.class
@Override @Nullable <span class="code-keyword" style="color: #000091">protected</span> IdPAttribute doAttributeDefinitionResolve(
92 @Nonnull <span class="code-keyword" style="color: #000091">final</span> AttributeResolutionContext resolutionContext,
93 @Nonnull <span class="code-keyword" style="color: #000091">final</span> AttributeResolverWorkContext workContext) <span class="code-keyword" style="color: #000091">throws</span> ResolutionException {
94
95 <span class="code-keyword" style="color: #000091">final</span> ProfileRequestContext prc = prcLookupStrategy.apply(resolutionContext);
96 <span class="code-keyword" style="color: #000091">final</span> List<IdPAttributeValue<?>> results = attributeValuesFunction.apply(prc);
97
<span class="code-comment" style="color: #808080">//IS THIS THE ISSUE?
</span>98 log.debug(<span class="code-quote" style="color: #009100">"{} Generated {} values."</span>, getLogPrefix(), results.size());
99 log.trace(<span class="code-quote" style="color: #009100">"{} Values:"</span>, getLogPrefix(), results);
100 <span class="code-keyword" style="color: #000091">final</span> IdPAttribute attribute = <span class="code-keyword" style="color: #000091">new</span> IdPAttribute(getId());
101 attribute.setValues(results);
102 <span class="code-keyword" style="color: #000091">return</span> attribute;
103 }
</pre>
</div>
</div>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/net/shibboleth/idp/attribute/resolver/ad/impl/SubjectDerivedAttributeValuesFunction.class
@Nullable
<span class="code-keyword" style="color: #000091">public</span> List<IdPAttributeValue<?>> apply(@Nullable ProfileRequestContext prc)
{
SubjectContext cs = (SubjectContext)<span class="code-keyword" style="color: #000091">this</span>.scLookupStrategy.apply(prc);
List<IdPAttributeValue<?>> results = <span class="code-keyword" style="color: #000091">new</span> ArrayList(1);
<span class="code-keyword" style="color: #000091">for</span> (Subject subject : cs.getSubjects()) {
<span class="code-keyword" style="color: #000091">for</span> (Principal principal : subject.getPrincipals())
{
List<IdPAttributeValue<?>> values = (List)<span class="code-keyword" style="color: #000091">this</span>.attributesValueFunction.apply(principal);
<span class="code-keyword" style="color: #000091">if</span> ((<span class="code-keyword" style="color: #000091">null</span> != values) && (!values.isEmpty())) {
results.addAll(values);
}
}
}
<span class="code-keyword" style="color: #000091">if</span> (results.isEmpty())
{
<span class="code-keyword" style="color: #000091">this</span>.log.info(<span class="code-quote" style="color: #009100">"{} generated no values, attrribute no resolved."</span>, getLogPrefix());
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
}
<span class="code-keyword" style="color: #000091">this</span>.log.debug(<span class="code-quote" style="color: #009100">"{} Generated {} values."</span>, getLogPrefix(), <span class="code-object" style="color: #910091">Integer</span>.valueOf(results.size()));
<span class="code-keyword" style="color: #000091">this</span>.log.trace(<span class="code-quote" style="color: #009100">"{} Values:"</span>, getLogPrefix(), results);
<span class="code-keyword" style="color: #000091">return</span> results;
}
</pre>
</div>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1131#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-60e5c982-6f0d-43dc-9de3-6d9fed3312f6" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1131#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.0.10#70120-<span title="37e3d7a6fc4d580639533e7f7c232c925e554a6a" data-commit-id="37e3d7a6fc4d580639533e7f7c232c925e554a6a}">sha1:37e3d7a</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-b64a96b6-6425-444a-b619-efb3089a0d19" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>