<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> 
<html xmlns="http://www.w3.org/1999/xhtml"> 
    <head> 
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> 
        <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://issues.shibboleth.net/jira" /> 
        <title>Message Title</title> 
    </head> 
    <body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429"> 
        <table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
            <!-- header here --> 
            <tr> 
                <td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px"> 
                    <table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
                        <tr> 
                            <td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-b9c10858-cdfb-45cb-b976-acaf175418d9" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" /> 
                            </td> 
                            <td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="esbitnjxxmhh96nfwtqbwsj6aw4=@https://signon.deakin.edu.au/idp/shibboleth" id="email_esbitnjxxmhh96nfwtqbwsj6aw4=@https://signon.deakin.edu.au/idp/shibboleth" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=esbitnjxxmhh96nfwtqbwsj6aw4%3D%40https%3A%2F%2Fsignon.deakin.edu.au%2Fidp%2Fshibboleth" style="color:#3b73af;; color: #3b73af; text-decoration: none">Aaron Howell</a> <strong>commented</strong> on <a href="https://issues.shibboleth.net/jira/browse/IDP-1094" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-1133d29a-fa22-4fda-ab60-1ab20b606be9" height="16" width="16" border="0" align="absmiddle" alt="Improvement" /> IDP-1094</a> 
                            </td> 
                        </tr> 
                    </table> 
                </td> 
            </tr> 
            <tr> 
                <td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px"> 
                    <table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate"> 
                        <tr> 
                            <!-- there needs to be content in the cell for it to render in some clients --> 
                            <td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
                                 
                            </td> 
                        </tr> 
                        <tr> 
                            <td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff"> 
                                <table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
                                    <tr> 
                                        <td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1094" style="color: #3b73af; text-decoration: none">Re: Provide logback-access with other logback jars</a> </span> 
                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                        <tr> 
                            <td id="text-paragraph-pattern-top" class="email-content-main mobile-expand  comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0"> 
                                <table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px"> 
                                    <tr> 
                                        <td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> 
                                            <p style="margin: 10px 0 0 0">Well firstly Jetty 9.4 has just come out and includes some inbuilt support for logback (if you have outbound internet access, enabling the module will even download the required libraries - which helps heaps with my original problem). The following modules seems to replicate the recommended Jetty configuration by Shibboleth. I realise you will probably want to test with 9.4 before recommending. (note I've logged a config bug with logback-access.mod <a href="https://github.com/eclipse/jetty.project/issues/1188" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://github.com/eclipse/jetty.project/issues/1188</a>)</p> 
                                            <ul class="alternate" type="square"> 
                                                <li>
                                                    logging-logback.mod, logback-access.mod, console-capture.mod
                                                </li> 
                                            </ul> 
                                            <p style="margin: 10px 0 0 0">With the current template - some of the features you have are core requirements - however some are definitely optional - so it would appear to need to be a little more modular</p> 
                                            <ul class="alternate" type="square"> 
                                                <li>
                                                    In my case SSL is offloaded to a hardware device and I imagine would be a fairly common configuration:
                                                </li> 
                                                <li>
                                                    so I’ve had to disable --module=https and --module=ssl and enable --module=http-forwarded (so that Jetty indicates the server is secure
                                                </li> 
                                                <li>
                                                    I don't have --module=backchannel as support here isn't required
                                                </li> 
                                                <li>
                                                    on a side note jetty-backchannel.xml should be renamed - as it's name implies that it is jetty supplied.
                                                </li> 
                                                <li>
                                                    I've added "jetty.httpConfig.sendServerVersion=false" as a security hardening measure (one of the first things we'd be picked up on in an audit)
                                                </li> 
                                                <li>
                                                    start.ini vs start.d - it is recommended to chose one or the other (<a href="https://www.eclipse.org/jetty/documentation/9.4.x/startup.html" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://www.eclipse.org/jetty/documentation/9.4.x/startup.html</a>)
                                                </li> 
                                                <li>
                                                    I’d be inclined to use start.d as it allows admins to be more modular in their approach
                                                </li> 
                                                <li>
                                                    I can't work out why some configuration have been imported and changed from the defaults except to rename a few parameter names:
                                                </li> 
                                                <li>
                                                    jetty-http.xml to change from default jetty.http.host & jetty.http.port
                                                </li> 
                                                <li>
                                                    jetty-deploy.xml - don’t need to load manually if you use start.d
                                                </li> 
                                                <li>
                                                    jetty-ssl-context.xml appears to be the only one changed for a reason
                                                </li> 
                                            </ul> 
                                            <p style="margin: 10px 0 0 0">Ultimately I would recommend that instead of one set of configuration files that some Modules are written instead. A basic structure for known requirements (I’ve uploaded some examples I have just been testing with):</p> 
                                            <ul class="alternate" type="square"> 
                                                <li>
                                                    idp-core.mod
                                                </li> 
                                                <li>
                                                    idp-ssl-local.mod
                                                </li> 
                                                <li>
                                                    idp-ssl-offloaded.mod
                                                </li> 
                                                <li>
                                                    idp-logging.mod (keep separate incase users want to roll their own logging solution)
                                                </li> 
                                                <li>
                                                    idp-backchannel.mod<br /> There would be some extra files with the modules - like I'm pretty sure you could chuck in a default deployment descriptor in to webapps upon activation of the idp-core module.
                                                </li> 
                                            </ul> 
                                            <p style="margin: 10px 0 0 0">Then it is simply a matter of something like "sudo /usr/bin/java -jar /opt/jetty/start.jar --add-to-start=idp-ssl-offloaded,idp-logging" to set up a basic install - and all that was provided was the modules directory.</p> 
                                            <p style="margin: 10px 0 0 0">Cheers<br /> Aaron</p> 
                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                        <tr> 
                            <td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff"> 
                                <table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> 
                                    <tr> 
                                        <td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0"> 
                                            <table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
                                                <tr> 
                                                    <td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1094#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-b53ecb20-bbc9-401c-9180-939475a69739" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a> 
                                                    </td> 
                                                    <td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.shibboleth.net/jira/browse/IDP-1094#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> 
                                                    </td> 
                                                </tr> 
                                            </table> 
                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                        <!-- there needs to be content in the cell for it to render in some clients --> 
                        <tr> 
                            <td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
                                 
                            </td> 
                        </tr> 
                    </table> 
                </td> 
            </tr> 
            <tr> 
                <td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px"> 
                    <table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
                        <tr> 
                            <td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
                                 This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.0.10#70120-<span title="37e3d7a6fc4d580639533e7f7c232c925e554a6a" data-commit-id="37e3d7a6fc4d580639533e7f7c232c925e554a6a}">sha1:37e3d7a</span>)</span> 
                            </td> 
                            <td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top"> 
                                <table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
                                    <tr> 
                                        <td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-b287453b-4f5e-4ef3-8d71-918bfe88d792" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" /> 
                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                    </table> 
                </td> 
            </tr> 
        </table>   
    </body>
</html>