<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://issues.shibboleth.net/jira" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-cantor.2@osu.edu-ea915cc7-139b-47e5-9d86-27643ae2f6c1" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cantor.2@osu.edu" id="email_cantor.2@osu.edu" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=cantor.2%40osu.edu" style="color:#3b73af;; color: #3b73af; text-decoration: none">Scott Cantor</a> <strong>commented</strong> on <a href="https://issues.shibboleth.net/jira/browse/IDP-791" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-subtask_alternate-fc17759c-cf3a-4504-abda-0f9ef7b0f8e4" height="16" width="16" border="0" align="absmiddle" alt="Sub-task" /> IDP-791</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-791" style="color: #3b73af; text-decoration: none">Re: Add client-storage flows to CAS login flow</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">FWIW, I think this corrects it, so maybe worth doing...</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
Index: src/main/resources/system/flows/cas/login/login-flow.xml
===================================================================
--- src/main/resources/system/flows/cas/login/login-flow.xml (revision 7938)
+++ src/main/resources/system/flows/cas/login/login-flow.xml (working copy)
@@ -10,6 +10,18 @@
<evaluate result=<span class="code-quote" style="color: #009100">"flowScope.hasAuthenticationContext"</span> expression=<span class="code-quote" style="color: #009100">"<span class="code-keyword" style="color: #000091; color: #009100">false</span>"</span> />
</on-entry>
<evaluate expression=<span class="code-quote" style="color: #009100">"InitializeProfileRequestContext"</span>/>
+ <evaluate expression=<span class="code-quote" style="color: #009100">"PopulateClientStorageLoadContext"</span> />
+ <evaluate expression=<span class="code-quote" style="color: #009100">"'proceed'"</span> />
+ <transition on=<span class="code-quote" style="color: #009100">"proceed"</span> to=<span class="code-quote" style="color: #009100">"ClientStorageLoad"</span> />
+ <transition on=<span class="code-quote" style="color: #009100">"NoLoadNeeded"</span> to=<span class="code-quote" style="color: #009100">"ContinueLogin"</span> />
+ </action-state>
+
+ <subflow-state id=<span class="code-quote" style="color: #009100">"ClientStorageLoad"</span> subflow=<span class="code-quote" style="color: #009100">"client-storage/read"</span>>
+ <input name=<span class="code-quote" style="color: #009100">"calledAsSubflow"</span> value=<span class="code-quote" style="color: #009100">"<span class="code-keyword" style="color: #000091; color: #009100">true</span>"</span> />
+ <transition on=<span class="code-quote" style="color: #009100">"proceed"</span> to=<span class="code-quote" style="color: #009100">"ContinueLogin"</span>/>
+ </subflow-state>
+
+ <action-state id=<span class="code-quote" style="color: #009100">"ContinueLogin"</span>>
<evaluate expression=<span class="code-quote" style="color: #009100">"PopulateSessionContext"</span>/>
<evaluate expression=<span class="code-quote" style="color: #009100">"InitializeLogin"</span> />
<evaluate expression=<span class="code-quote" style="color: #009100">"BuildRelyingPartyContext"</span> />
@@ -17,17 +29,10 @@
<evaluate expression=<span class="code-quote" style="color: #009100">"SelectRelyingPartyConfiguration"</span> />
<evaluate expression=<span class="code-quote" style="color: #009100">"SelectProfileConfiguration"</span> />
<evaluate expression=<span class="code-quote" style="color: #009100">"PublishProtocolRequest"</span> />
- <evaluate expression=<span class="code-quote" style="color: #009100">"PopulateClientStorageLoadContext"</span> />
<evaluate expression=<span class="code-quote" style="color: #009100">"'proceed'"</span> />
- <transition on=<span class="code-quote" style="color: #009100">"proceed"</span> to=<span class="code-quote" style="color: #009100">"ClientStorageLoad"</span> />
- <transition on=<span class="code-quote" style="color: #009100">"NoLoadNeeded"</span> to=<span class="code-quote" style="color: #009100">"CheckAuthenticationRequired"</span> />
+ <transition on=<span class="code-quote" style="color: #009100">"proceed"</span> to=<span class="code-quote" style="color: #009100">"CheckAuthenticationRequired"</span> />
</action-state>
- <subflow-state id=<span class="code-quote" style="color: #009100">"ClientStorageLoad"</span> subflow=<span class="code-quote" style="color: #009100">"client-storage/read"</span>>
- <input name=<span class="code-quote" style="color: #009100">"calledAsSubflow"</span> value=<span class="code-quote" style="color: #009100">"<span class="code-keyword" style="color: #000091; color: #009100">true</span>"</span> />
- <transition on=<span class="code-quote" style="color: #009100">"proceed"</span> to=<span class="code-quote" style="color: #009100">"CheckAuthenticationRequired"</span>/>
- </subflow-state>
-
<decision-state id=<span class="code-quote" style="color: #009100">"CheckAuthenticationRequired"</span>>
<<span class="code-keyword" style="color: #000091">if</span> test=<span class="code-quote" style="color: #009100">"flowScope.serviceTicketRequest.gateway"</span>
then=<span class="code-quote" style="color: #009100">"PrepareForRedirectToService"</span>
</pre>
</div>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.shibboleth.net/jira/browse/IDP-791#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-fd153e1d-daa3-48df-8190-169d2269d2fb" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.shibboleth.net/jira/browse/IDP-791#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.4.1#64016-<span title="5d7581434f35c063b7031942e62ed4d72a97fa9c" data-commit-id="5d7581434f35c063b7031942e62ed4d72a97fa9c}">sha1:5d75814</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-9b2156ac-1b24-451c-8e43-3d9676843c8b" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>