<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#ffffff" style="background-color:#ffffff;color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://shibboleth.net/images/shib_240x83.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://issues.shibboleth.net/jira/secure/useravatar?avatarId=10202" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="putmanb@shibboleth.net" id="email_putmanb@shibboleth.net" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=putmanb%40shibboleth.net" style="color:#326ca6;">Brent Putman</a>
commented on <img src="https://issues.shibboleth.net/jira/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://issues.shibboleth.net/jira/browse/SIDP-624'>SIDP-624</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='https://issues.shibboleth.net/jira/browse/SIDP-624'><strong>IdP stopping metadata retrieval</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>With some sleep-on-it time: In addition to the HC timeouts, I think it might be worthwhile to also fix the metadata providers so that they use their own Timer instance, if the effective one would otherwise be the default singleton bean one (shibboleth.TaskTimer).</p>
<p>This would seem easy and isolated, and we (well I) understand the code pretty well: 1) fix AbstractReloadingMetadataProvider ctor to allow it to be null 2) fix AbstractReloadingMetadataProviderBeanDefinitionParser so that if it's the well-known bean name, don't use that one; instead pass a null timer to the ctor. Unless the latter proves difficult to achieve in Spring, in which case I guess we do nothing (not sure about passing nulls for ctor arg values, whether it can wire by-type correctly. Maybe cast the null? e.g. '(Timer)null' ).</p>
<p>The reason is that: This seems like the majority case for failures and hangs. A very high percentage of IdP's are probably using HTTP metadata providers. A much smaller percentage are using reloadable services. Also, the providers are more likely to be pointing at a "foreign" resource, as where the services are more likely to point at a "local" resource, under the control/monitoring of the IdP owners.</p>
<p>I agree that the service stuff is a mess and I don't think we should try and fix any of that right now, if ever. At the very least we'd need more time to test and sort it all out.</p>
<p>In particular, I think that the base service destroy() calling Timer#cancel() is just a bug and/or there is an undocumented assumption that the BaseReloadableService <b>always</b> gets injected with its own Timer, which of course we aren't doing. Without that assumption I think it should really be storing a List<ResourceChangeWatcher> of the watchers (TimerTasks) that it creates and then cancels all of those in the destroy(). If destroy() actually were being invoked (good thing it's not...), we'd have a very different bug - all the shared Timer tasks in the system would be canceled every time a reloadable service got destroyed by the context! </p>
</div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->