<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#ffffff" style="background-color:#ffffff;color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://shibboleth.net/images/shib_240x83.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://issues.shibboleth.net/jira/secure/useravatar?ownerId=ian%40iay.org.uk&avatarId=10125" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="ian@iay.org.uk" id="email_ian@iay.org.uk" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=ian%40iay.org.uk" style="color:#326ca6;">Ian Young</a>
commented on <img src="https://issues.shibboleth.net/jira/images/icons/issuetypes/task.png" height="16" width="16" border="0" align="absmiddle" alt="Task"> <a style='color:#326ca6;text-decoration:none;' href='https://issues.shibboleth.net/jira/browse/MDA-113'>MDA-113</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='https://issues.shibboleth.net/jira/browse/MDA-113'><strong>review code with -Xlint:unchecked</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>If you turn on all the options in Eclipse under Java Compiler / Errors/Warnings / Generic Types these things all become visible, so actually using -Xlint:unchecked isn't required.</p>
<p>Rev 284 addresses all issues with the main source. I have not looked in detail at the tests; they are full of references to raw types and would need a significant amount of work, probably beyond any benefit that might be seen from it. Obviously it might make sense to be more careful with new tests and fix things up in passing where visible.</p>
<p>As an aside, I'm now less sure that the parameterisation of things in the MDA is actually done in the best way. In general, it's saying that things are <ItemType extends Item<?>> but that is pushing a lot of Item<?>s up to the top of the type tree. It may be that using the type of the wrapped element and ignoring the implementation type would be better.</p>
<p>For example, take the following definitions:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java"><span class="code-keyword">public</span> class PipelineDemultiplexerStage<ItemType <span class="code-keyword">extends</span> Item<?>> <span class="code-keyword">extends</span> BaseStage<ItemType>
<span class="code-keyword">public</span> <span class="code-keyword">abstract</span> class BaseStage<ItemType <span class="code-keyword">extends</span> Item<?>> <span class="code-keyword">extends</span>
AbstractDestructableIdentifiableInitializableComponent <span class="code-keyword">implements</span> Stage<ItemType> {
<span class="code-keyword">public</span> <span class="code-keyword">interface</span> Stage<ItemType <span class="code-keyword">extends</span> Item<?>> <span class="code-keyword">extends</span> DestructableComponent, IdentifiableComponent,
InitializableComponent {
<span class="code-keyword">public</span> void execute(@Nonnull @NonnullElements <span class="code-keyword">final</span> Collection<ItemType> itemCollection)
<span class="code-keyword">throws</span> StageProcessingException;
</pre>
</div></div>
<p>The actual parameter here might be something like DOMElementItem. This might be a better approach if carried through consistently:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java"><span class="code-keyword">public</span> class PipelineDemultiplexerStage<ItemType> <span class="code-keyword">extends</span> BaseStage<ItemType>
<span class="code-keyword">public</span> <span class="code-keyword">abstract</span> class BaseStage<ItemType> <span class="code-keyword">extends</span>
AbstractDestructableIdentifiableInitializableComponent <span class="code-keyword">implements</span> Stage<ItemType> {
<span class="code-keyword">public</span> <span class="code-keyword">interface</span> Stage<ItemType> <span class="code-keyword">extends</span> DestructableComponent, IdentifiableComponent,
InitializableComponent {
<span class="code-keyword">public</span> void execute(@Nonnull @NonnullElements <span class="code-keyword">final</span> Collection<Item<ItemType>> itemCollection)
<span class="code-keyword">throws</span> StageProcessingException;
</pre>
</div></div>
<p>The actual parameter here would end up being Element instead of DOMElementItem.</p>
<p>I'm not sure how dramatic a change this would be. It probably wouldn't affect Spring configurations at all, but it would require a lot of individual source changes.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->