<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#ffffff" style="background-color:#ffffff;color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://shibboleth.net/images/shib_240x83.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://issues.shibboleth.net/jira/secure/useravatar?avatarId=10202" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="dantech@idp.protectnetwork.org" id="email_dantech@idp.protectnetwork.org" href="https://issues.shibboleth.net/jira/secure/ViewProfile.jspa?name=dantech%40idp.protectnetwork.org" style="color:#326ca6;">dantech@idp.protectnetwork.org</a>
commented on <img src="https://issues.shibboleth.net/jira/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://issues.shibboleth.net/jira/browse/MDA-58'>MDA-58</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='https://issues.shibboleth.net/jira/browse/MDA-58'><strong>XMLSignatureSigningStage fails to properly sign metadata aggregated using the MDA</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>The fix almost works. </p>
<p>'m seeing that the new stage does add the ID, but when I run the<br/>
metadata through xmlsectool.sh --validateSchema --schemaDirectory<br/>
/tmp/mda/xsd/ --inFile /tmp/mda/federation/federation-metadata.xml</p>
<p>I get the following error stating the ID is not valid for NCName.</p>
<p>ERROR XmlSecTool - Invalid XML schema files, unable to validate XML<br/>
org.xml.sax.SAXParseException: cvc-datatype-valid.1.2.1:<br/>
'031ce108-b893-4b5a-9f83-bded6eebb46d' is not a valid value for<br/>
'NCName'.<br/>
at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.xs.XMLSchemaValidator$XSIErrorReporter.reportError(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.xs.XMLSchemaValidator.reportSchemaError(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.xs.XMLSchemaValidator.processOneAttribute(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.xs.XMLSchemaValidator.processAttributes(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.jaxp.validation.DOMValidatorHelper.beginNode(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.jaxp.validation.DOMValidatorHelper.validate(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.jaxp.validation.DOMValidatorHelper.validate(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at org.apache.xerces.jaxp.validation.ValidatorImpl.validate(Unknown<br/>
Source) ~<span class="error">[na:na]</span><br/>
at javax.xml.validation.Validator.validate(Unknown Source) ~<span class="error">[na:1.4.01]</span><br/>
at edu.internet2.middleware.security.XmlSecTool.schemaValidate(XmlSecTool.java:349)<br/>
<span class="error">[xmlsectool-1.1.5.jar:na]</span><br/>
at edu.internet2.middleware.security.XmlSecTool.main(XmlSecTool.java:148)<br/>
<span class="error">[xmlsectool-1.1.5.jar:na]</span></p>
<p>The ID xsd:ID field, which is basically an NCName, which must start with a Letter (or an underscore "_" ), but the value you generate starts with a Digit.</p>
<p>See: <a href="http://www.w3.org/TR/xmlschema-2/#ID" class="external-link">http://www.w3.org/TR/xmlschema-2/#ID</a><br/>
And: <a href="http://www.w3.org/TR/1999/REC-xml-names-19990114/#NT-NCName" class="external-link">http://www.w3.org/TR/1999/REC-xml-names-19990114/#NT-NCName</a></p>
</div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->