[java-idp-plugin-oidc-op-oidfed] branch main updated: Improve metadata policy test vector success case testing

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-idp-plugin-oidc-op-oidfed.

View the commit online:
https://codeberg.org/Shibboleth/java-idp-plugin-oidc-op-oidfed/commit/bb7b849492e6a1b390ccacb0b43db78356cbf979

The following commit(s) were added to refs/heads/main by this push:
     new bb7b849  Improve metadata policy test vector success case testing
bb7b849 is described below

commit bb7b849492e6a1b390ccacb0b43db78356cbf979
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Wed Sep 30 14:40:05 2026 +0300

    Improve metadata policy test vector success case testing
    
    - Iterate over both input and resolved metadata claims to verify the actual result in all cases
---
 .../oidfed/PushedAuthorizeFlowAutomaticRegistrationTest.java     | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/idp-oidfed-op-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/PushedAuthorizeFlowAutomaticRegistrationTest.java b/idp-oidfed-op-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/PushedAuthorizeFlowAutomaticRegistrationTest.java
index 8f0a258..59fefaf 100644
--- a/idp-oidfed-op-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/PushedAuthorizeFlowAutomaticRegistrationTest.java
+++ b/idp-oidfed-op-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/PushedAuthorizeFlowAutomaticRegistrationTest.java
@@ -28,6 +28,7 @@ import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.UUID;
+import java.util.stream.Stream;
 
 import org.opensaml.profile.context.ProfileRequestContext;
 import org.opensaml.storage.StorageService;
@@ -507,7 +508,9 @@ public class PushedAuthorizeFlowAutomaticRegistrationTest extends AbstractFedera
                     assert enforcedMetadata != null;
                     final Map<String, Object> rpMetadata = enforcedMetadata.getOpenidRelyingPartyMetadata();
                     assert rpMetadata != null;
-                    for (final String claim : metadata.keySet()) {
+                    for (final String claim : Stream
+                            .concat(metadata.keySet().stream(), resolved.keySet().stream()).distinct()
+                            .toList()) {
                         final Object actual = rpMetadata.get(claim);
                         if (resolved.get(claim) instanceof Boolean flag) {
                             if (flag) {
@@ -520,8 +523,8 @@ public class PushedAuthorizeFlowAutomaticRegistrationTest extends AbstractFedera
                                     .map(String.class::cast).toList();
                             final Collection<String> actualStrings = ((Collection<?>) actual).stream()
                                     .map(String.class::cast).toList();
-                            Assert.assertTrue(expectedStrings.containsAll(actualStrings));
-                            Assert.assertTrue(actualStrings.containsAll(expectedStrings));
+                            Assert.assertTrue(expectedStrings.containsAll(actualStrings), ERROR_MESSAGE);
+                            Assert.assertTrue(actualStrings.containsAll(expectedStrings), ERROR_MESSAGE);
                         } else {
                             Assert.assertEquals(actual, resolved.get(claim), ERROR_MESSAGE);
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.