[java-oidfed-common] 03/05: Declare index as final and exploit it in the if-clause.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-oidfed-common.

View the commit online:
https://codeberg.org/Shibboleth/java-oidfed-common/commit/3047b6fce7cf4009a5b9b2a505c8078e36c03c19

commit 3047b6fce7cf4009a5b9b2a505c8078e36c03c19
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Wed Sep 23 10:13:04 2026 +0300

    Declare index as final and exploit it in the if-clause.
---
 .../metadata/cache/trustchain/DefaultTrustChainFetchingStrategy.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/oidfed-common-impl/src/main/java/net/shibboleth/oidfed/metadata/cache/trustchain/DefaultTrustChainFetchingStrategy.java b/oidfed-common-impl/src/main/java/net/shibboleth/oidfed/metadata/cache/trustchain/DefaultTrustChainFetchingStrategy.java
index 38bb8a1..0072b9d 100644
--- a/oidfed-common-impl/src/main/java/net/shibboleth/oidfed/metadata/cache/trustchain/DefaultTrustChainFetchingStrategy.java
+++ b/oidfed-common-impl/src/main/java/net/shibboleth/oidfed/metadata/cache/trustchain/DefaultTrustChainFetchingStrategy.java
@@ -401,8 +401,8 @@ public class DefaultTrustChainFetchingStrategy extends AbstractIdentifiableIniti
         if (preSelectedChain.isEmpty()) {
             return true;
         }
-        int index = chain.size() > 1 ? chain.size() - 1 : chain.size();
-        if (preSelectedChain.size() < chain.size() || !preSelectedChain.get(index).equals(authority)) {
+        final int index = chain.size() > 1 ? chain.size() - 1 : chain.size();
+        if (preSelectedChain.size() <= index || !preSelectedChain.get(index).equals(authority)) {
             log.debug("Ignoring authority {} as it doesn't match with the preselected chain {}", authority,
                     preSelectedChain);
             return false;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.