[java-plugin-shibd-oidc] 09/11: Improve test, remove use parameter

Codeberg noreply at shibboleth.net
Wed Oct 7 14:29:14 UTC 2026


This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch dev/JSHIBDOIDC-31-cred-resolver
in repository java-plugin-shibd-oidc.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd-oidc/commit/d22698f5cc7c38a053cf03bb02ea61368d1776fe

commit d22698f5cc7c38a053cf03bb02ea61368d1776fe
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Mon Oct 5 11:22:09 2026 +0100

    Improve test, remove use parameter
---
 .../impl/JWKCredentialStorageServiceResolverTest.java    | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/sp-oidc-impl/src/test/java/net/shibboleth/sp/oidc/profile/credential/impl/JWKCredentialStorageServiceResolverTest.java b/sp-oidc-impl/src/test/java/net/shibboleth/sp/oidc/profile/credential/impl/JWKCredentialStorageServiceResolverTest.java
index fd8681b..04c6a38 100644
--- a/sp-oidc-impl/src/test/java/net/shibboleth/sp/oidc/profile/credential/impl/JWKCredentialStorageServiceResolverTest.java
+++ b/sp-oidc-impl/src/test/java/net/shibboleth/sp/oidc/profile/credential/impl/JWKCredentialStorageServiceResolverTest.java
@@ -216,7 +216,7 @@ public class JWKCredentialStorageServiceResolverTest {
     	final KeyGenerator generator = KeyGenerator.getInstance("HmacSHA256");
     	generator.init(256);
     	final SecretKey generatedSecretKey = generator.generateKey();
-        generateSymmetricKeyJWK(Path.of(directory.toString(), "sp-signing.jwk"), KeyUse.SIGNATURE, 
+        generateSymmetricKeyJWK(Path.of(directory.toString(), "sp-signing.jwk"), null, 
         		generatedSecretKey, JWSAlgorithm.HS256);
         
         final FilesystemStorageService storage = new FilesystemStorageService();
@@ -324,16 +324,18 @@ public class JWKCredentialStorageServiceResolverTest {
      * @param alg the algorithm
      * @throws Exception on error
      */
-    private void generateSymmetricKeyJWK(@Nonnull final Path keyPath, @Nonnull final KeyUse use, 
+    private void generateSymmetricKeyJWK(@Nonnull final Path keyPath, @Nullable final KeyUse use, 
     		final SecretKey secretKey, final Algorithm alg) throws Exception {
 	
-    	final OctetSequenceKey key = new OctetSequenceKey.Builder(secretKey)
-    			.keyUse(use)
+    	final var keyBuilder = new OctetSequenceKey.Builder(secretKey)
     			.algorithm(alg)
-    			.keyID("test")
-    			.build();
+    			.keyID("test");
     	
-    	Files.writeString(keyPath, key.toJSONString(), StandardCharsets.UTF_8);
+    	if (use != null) {
+    		keyBuilder.keyUse(use);
+    	}
+    	
+    	Files.writeString(keyPath, keyBuilder.build().toJSONString(), StandardCharsets.UTF_8);
     }
     
     /**

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list