[cpp-sp] branch main updated: Fix order of decryption members in session read.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository cpp-sp.

View the commit online:
https://codeberg.org/Shibboleth/cpp-sp/commit/84196267d7ef4bfaa66fd3fc30c1225dcda0d062

The following commit(s) were added to refs/heads/main by this push:
     new 84196267 Fix order of decryption members in session read.
84196267 is described below

commit 84196267d7ef4bfaa66fd3fc30c1225dcda0d062
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Tue Oct 6 11:26:37 2026 -0400

    Fix order of decryption members in session read.
---
 shibsp/session/impl/CookieSessionCache.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/shibsp/session/impl/CookieSessionCache.cpp b/shibsp/session/impl/CookieSessionCache.cpp
index c0c3ca5f..f2ec747f 100644
--- a/shibsp/session/impl/CookieSessionCache.cpp
+++ b/shibsp/session/impl/CookieSessionCache.cpp
@@ -199,19 +199,19 @@ DDF CookieSessionCache::cache_read(
     DDFJanitor injanitor(in);
     DDF decList = in.addmember("decrypt").list();
 
+    DDF decChild1(nullptr);
+    decList.add((decChild1.string(encryptedSession)));
+
     if (timeout) {
         const char* encryptedTimestamp = m_lastUsedCookieManager->getCookieValue(*request);
         if (!encryptedTimestamp || !*encryptedTimestamp) {
             log(WARN_MARK, "unable to load encrypted timestamp for session (%s) from cookie", key);
             throw SessionException("Unable to load encrypted timestamp for session from cookie.");
         }
-        DDF decChild1(nullptr);
-        decList.add((decChild1.string(encryptedTimestamp)));
+        DDF decChild2(nullptr);
+        decList.add((decChild2.string(encryptedTimestamp)));
     }
 
-    DDF decChild2(nullptr);
-    decList.add((decChild2.string(encryptedSession)));
-
     DDF out;
     try {
         // Add new timestamp to encrypt inside try/catch in case it throws a lexical_cast exception.

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.