[java-plugin-shibd] branch main updated: Use a custom DataSealer that provides URL-safe encoding.

[Codeberg]

This is an automated email from the git hooks/post-receive script.

codeberg pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
https://codeberg.org/Shibboleth/java-plugin-shibd/commit/7fccf9d8418a3b9c6e9b558f7b26f8213c205584

The following commit(s) were added to refs/heads/main by this push:
     new 7fccf9d  Use a custom DataSealer that provides URL-safe encoding.
7fccf9d is described below

commit 7fccf9d8418a3b9c6e9b558f7b26f8213c205584
Author: Scott Cantor <scott at restingparrotsoftware.com>
AuthorDate: Mon Oct 5 11:43:39 2026 -0400

    Use a custom DataSealer that provides URL-safe encoding.
---
 .../main/resources/META-INF/net.shibboleth.idp/postconfig.xml  | 10 ++++++++++
 .../net/shibboleth/idp/flows/sp/sealer/sealer-beans.xml        |  2 +-
 .../src/test/java/net/shibboleth/sp/flows/SealerFlowTest.java  |  2 +-
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/sp-conf-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml b/sp-conf-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
index be74e9f..080fde1 100644
--- a/sp-conf-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
+++ b/sp-conf-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
@@ -135,6 +135,16 @@
         class="net.shibboleth.sp.util.TemplatedStringLookupStrategy"
         p:velocityEngine-ref="shibboleth.VelocityEngine" />
 
+    <!-- Use a URL-safe encoding. -->
+    <bean id="shibboleth.sp.DataSealer" lazy-init="true"
+            class="net.shibboleth.shared.security.DataSealer"
+            p:keyStrategy-ref="#{ '%{idp.sealer.keyStrategy:shibboleth.DataSealerKeyStrategy}'.trim() }"
+            p:lockedAtStartup="#{!environment.containsProperty('idp.sealer.keyStrategy') and (!environment.containsProperty('idp.sealer.storePassword') or !environment.containsProperty('idp.sealer.keyPassword')) }">
+        <property name="encoder">
+            <bean class="org.apache.commons.codec.binary.Base64" c:_0="0" c:_1="&#x0A;" c:_2="true" />
+        </property>
+    </bean>
+
     <!-- Audit beans. -->
 
     <util:map id="shibboleth.sp.DefaultAuditFormattingMap">
diff --git a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/sealer/sealer-beans.xml b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/sealer/sealer-beans.xml
index 10955a7..65024b1 100644
--- a/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/sealer/sealer-beans.xml
+++ b/sp-conf-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/sp/sealer/sealer-beans.xml
@@ -13,6 +13,6 @@
     <bean id="DoSealerOperation"
         class="net.shibboleth.sp.profile.impl.DoSealerOperation" scope="prototype"
         p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier"
-        p:dataSealer-ref="#{'%{sp.dataSealer:shibboleth.DataSealer}'.trim()}" />
+        p:dataSealer-ref="#{'%{sp.dataSealer:shibboleth.sp.DataSealer}'.trim()}" />
 
 </beans>
diff --git a/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/SealerFlowTest.java b/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/SealerFlowTest.java
index c1b0a0f..b5e7e1f 100644
--- a/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/SealerFlowTest.java
+++ b/sp-conf-impl/src/test/java/net/shibboleth/sp/flows/SealerFlowTest.java
@@ -46,7 +46,7 @@ public class SealerFlowTest extends AbstractSPFlowTest {
     @Nonnull public static final String TEST_VALUE = "testValue";
     
     @Autowired
-    @Qualifier("shibboleth.DataSealer")
+    @Qualifier("shibboleth.sp.DataSealer")
     @Nullable private DataSealer dataSealer;
 
     protected SealerFlowTest() {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.